* [PATCH] git-svn: always initialize with core.autocrlf=false [not found] <cover.1239276588u.git.johannes.schindelin@gmx.de> @ 2009-04-09 11:29 ` Johannes Schindelin 2009-04-09 16:59 ` Eric Wong 0 siblings, 1 reply; 4+ messages in thread From: Johannes Schindelin @ 2009-04-09 11:29 UTC (permalink / raw) To: git, gitster; +Cc: Eric Wong It has been reported time and time again in relation to msysGit that git-svn does not work well when core.autocrlf has any value other than 'false'. So let's make it so by default. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- git-svn.perl | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/git-svn.perl b/git-svn.perl index 8be6be0..d4e8fc8 100755 --- a/git-svn.perl +++ b/git-svn.perl @@ -325,6 +325,7 @@ sub do_git_init_db { command_noisy(@init_db); $_repository = Git->repository(Repository => ".git"); } + command_noisy('config', 'core.autocrlf', 'false'); my $set; my $pfx = "svn-remote.$Git::SVN::default_repo_id"; foreach my $i (keys %icv) { -- 1.6.2.1.613.g25746 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] git-svn: always initialize with core.autocrlf=false 2009-04-09 11:29 ` [PATCH] git-svn: always initialize with core.autocrlf=false Johannes Schindelin @ 2009-04-09 16:59 ` Eric Wong 2009-04-09 17:21 ` Ferry Huberts (Pelagic) 0 siblings, 1 reply; 4+ messages in thread From: Eric Wong @ 2009-04-09 16:59 UTC (permalink / raw) To: Johannes Schindelin; +Cc: git, gitster Johannes Schindelin <johannes.schindelin@gmx.de> wrote: > It has been reported time and time again in relation to msysGit that > git-svn does not work well when core.autocrlf has any value other than > 'false'. So let's make it so by default. > > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Acked-by: Eric Wong <normalperson@yhbt.net> > --- > git-svn.perl | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/git-svn.perl b/git-svn.perl > index 8be6be0..d4e8fc8 100755 > --- a/git-svn.perl > +++ b/git-svn.perl > @@ -325,6 +325,7 @@ sub do_git_init_db { > command_noisy(@init_db); > $_repository = Git->repository(Repository => ".git"); > } > + command_noisy('config', 'core.autocrlf', 'false'); > my $set; > my $pfx = "svn-remote.$Git::SVN::default_repo_id"; > foreach my $i (keys %icv) { > -- > 1.6.2.1.613.g25746 -- Eric Wong ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] git-svn: always initialize with core.autocrlf=false 2009-04-09 16:59 ` Eric Wong @ 2009-04-09 17:21 ` Ferry Huberts (Pelagic) 2009-04-09 18:30 ` Johannes Schindelin 0 siblings, 1 reply; 4+ messages in thread From: Ferry Huberts (Pelagic) @ 2009-04-09 17:21 UTC (permalink / raw) To: Eric Wong; +Cc: Johannes Schindelin, git, gitster Eric Wong wrote: > Johannes Schindelin <johannes.schindelin@gmx.de> wrote: >> It has been reported time and time again in relation to msysGit that >> git-svn does not work well when core.autocrlf has any value other than >> 'false'. So let's make it so by default. >> >> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> > > Acked-by: Eric Wong <normalperson@yhbt.net> > >> --- >> git-svn.perl | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/git-svn.perl b/git-svn.perl >> index 8be6be0..d4e8fc8 100755 >> --- a/git-svn.perl >> +++ b/git-svn.perl >> @@ -325,6 +325,7 @@ sub do_git_init_db { >> command_noisy(@init_db); >> $_repository = Git->repository(Repository => ".git"); >> } >> + command_noisy('config', 'core.autocrlf', 'false'); >> my $set; >> my $pfx = "svn-remote.$Git::SVN::default_repo_id"; >> foreach my $i (keys %icv) { >> -- >> 1.6.2.1.613.g25746 > funny that this kind of seems to get through while my suggestion (and proff by tests) to do the same for the cvs-import stuff resulted in hefty discussions and no consensus on what to do, the result of which is to do nothing. i guess i couldn't make myself clear enough? ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] git-svn: always initialize with core.autocrlf=false 2009-04-09 17:21 ` Ferry Huberts (Pelagic) @ 2009-04-09 18:30 ` Johannes Schindelin 0 siblings, 0 replies; 4+ messages in thread From: Johannes Schindelin @ 2009-04-09 18:30 UTC (permalink / raw) To: Ferry Huberts (Pelagic); +Cc: Eric Wong, git, gitster Hi, On Thu, 9 Apr 2009, Ferry Huberts (Pelagic) wrote: > Eric Wong wrote: > > Johannes Schindelin <johannes.schindelin@gmx.de> wrote: > >> It has been reported time and time again in relation to msysGit that > >> git-svn does not work well when core.autocrlf has any value other than > >> 'false'. So let's make it so by default. > >> > >> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> > > > > Acked-by: Eric Wong <normalperson@yhbt.net> > > > >> --- > >> git-svn.perl | 1 + > >> 1 files changed, 1 insertions(+), 0 deletions(-) > >> > >> diff --git a/git-svn.perl b/git-svn.perl > >> index 8be6be0..d4e8fc8 100755 > >> --- a/git-svn.perl > >> +++ b/git-svn.perl > >> @@ -325,6 +325,7 @@ sub do_git_init_db { > >> command_noisy(@init_db); > >> $_repository = Git->repository(Repository => ".git"); > >> } > >> + command_noisy('config', 'core.autocrlf', 'false'); > >> my $set; > >> my $pfx = "svn-remote.$Git::SVN::default_repo_id"; > >> foreach my $i (keys %icv) { > >> -- > >> 1.6.2.1.613.g25746 > > > funny that this kind of seems to get through while my suggestion (and > proff by tests) to do the same for the cvs-import stuff resulted in > hefty discussions and no consensus on what to do, the result of which is > to do nothing. i guess i couldn't make myself clear enough? Actually, I was very much in favor of it. Care to resend, for our pleasure, pretty please? Thanks, Dscho ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-04-09 18:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1239276588u.git.johannes.schindelin@gmx.de>
2009-04-09 11:29 ` [PATCH] git-svn: always initialize with core.autocrlf=false Johannes Schindelin
2009-04-09 16:59 ` Eric Wong
2009-04-09 17:21 ` Ferry Huberts (Pelagic)
2009-04-09 18:30 ` Johannes Schindelin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox