Git development
 help / color / mirror / Atom feed
* [PATCH] improve error message in config.c
@ 2009-04-29 21:27 Alex Riesen
  0 siblings, 0 replies; only message in thread
From: Alex Riesen @ 2009-04-29 21:27 UTC (permalink / raw)
  To: git; +Cc: Junio C Hamano

Show errno if opening a lockfile fails.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---

I miss them error codes greately. Especially when a problem is hard
to reproduce.

 config.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/config.c b/config.c
index 1750cfb..8bd953c 100644
--- a/config.c
+++ b/config.c
@@ -996,7 +996,7 @@ int git_config_set_multivar(const char* key, const char* value,
 	lock = xcalloc(sizeof(struct lock_file), 1);
 	fd = hold_lock_file_for_update(lock, config_filename, 0);
 	if (fd < 0) {
-		error("could not lock config file %s", config_filename);
+		error("could not lock config file %s: %s", config_filename, strerror(errno));
 		free(store.key);
 		ret = -1;
 		goto out_free;
-- 
1.6.3.rc3.39.g49fd5

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2009-04-29 21:28 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-29 21:27 [PATCH] improve error message in config.c Alex Riesen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox