From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Thomas Rast" <trast@student.ethz.ch>,
git@vger.kernel.org, "Björn Steinbrink" <B.Steinbrink@gmx.de>,
"Abhijit Menon-Sen" <ams@toroid.org>
Subject: Re: [PATCH] Make 'diff C^!' show the same diff as 'show C'
Date: Thu, 20 Aug 2009 18:34:24 -0400 [thread overview]
Message-ID: <20090820223424.GA5843@coredump.intra.peff.net> (raw)
In-Reply-To: <7vab1up1gz.fsf@alter.siamese.dyndns.org>
On Thu, Aug 20, 2009 at 03:25:16PM -0700, Junio C Hamano wrote:
> Thomas Rast <trast@student.ethz.ch> writes:
>
> > Ideally, we'd like 'git diff C^!' to show the same diff that 'git show C'
> > does (with log.showroot enabled). This gives easy access to a readable
> > diff for the commit, irrespective of how many parents it has and without
> > any trickery to remove the commit message from the git-show output.
>
> Not interested yet, as the "git show" discussion is not convincing at all.
>
> Is the message annoying enough to warrant this change?
I thought the same thing when I saw his message, but reading further,
the current output is nonsensical. So if not this patch, we should
probably at least complain about bogus input and die (though if it is
easy to make it work, why not...).
-Peff
next prev parent reply other threads:[~2009-08-20 22:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-20 22:10 [PATCH] Make 'diff C^!' show the same diff as 'show C' Thomas Rast
2009-08-20 22:25 ` Junio C Hamano
2009-08-20 22:34 ` Jeff King [this message]
2009-08-20 23:01 ` Junio C Hamano
2009-08-20 22:42 ` Thomas Rast
2009-08-20 23:03 ` Junio C Hamano
2009-08-20 23:31 ` Junio C Hamano
2009-08-20 23:35 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090820223424.GA5843@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=B.Steinbrink@gmx.de \
--cc=ams@toroid.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox