Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Thomas Rast <trast@student.ethz.ch>
Cc: git@vger.kernel.org, "Björn Steinbrink" <B.Steinbrink@gmx.de>,
	"Abhijit Menon-Sen" <ams@toroid.org>
Subject: Re: [PATCH] Make 'diff C^!' show the same diff as 'show C'
Date: Thu, 20 Aug 2009 15:25:16 -0700	[thread overview]
Message-ID: <7vab1up1gz.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <86d1201d8adf53c1f48c0f3526d8e81475b18244.1250806019.git.trast@student.ethz.ch> (Thomas Rast's message of "Fri\, 21 Aug 2009 00\:10\:07 +0200")

Thomas Rast <trast@student.ethz.ch> writes:

> Ideally, we'd like 'git diff C^!' to show the same diff that 'git show C'
> does (with log.showroot enabled).  This gives easy access to a readable
> diff for the commit, irrespective of how many parents it has and without
> any trickery to remove the commit message from the git-show output.

Not interested yet, as the "git show" discussion is not convincing at all.

Is the message annoying enough to warrant this change?

If that is indeed the case and if it is a common thing to ask, isn't it
more productive to teach "show" a way to do so in a simpler way than
doing, say,

	$ git show --pretty=format: HEAD

  reply	other threads:[~2009-08-20 22:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-20 22:10 [PATCH] Make 'diff C^!' show the same diff as 'show C' Thomas Rast
2009-08-20 22:25 ` Junio C Hamano [this message]
2009-08-20 22:34   ` Jeff King
2009-08-20 23:01     ` Junio C Hamano
2009-08-20 22:42   ` Thomas Rast
2009-08-20 23:03     ` Junio C Hamano
2009-08-20 23:31 ` Junio C Hamano
2009-08-20 23:35   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vab1up1gz.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=B.Steinbrink@gmx.de \
    --cc=ams@toroid.org \
    --cc=git@vger.kernel.org \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox