[PATCH] git svn: add (failing) test for a git svn gc followed by a git svn mkdirs

[PATCH] git svn: add (failing) test for a git svn gc followed by a git svn mkdirs

[Robert Zeh]

git svn gc will compress the unhandled.log files that git svn mkdirs reads,
causing git svn mkdirs to skip directory creation.
---
 t/t9152-svn-empty-dirs-after-gc.sh |   41 ++++++++++++++++++++++++++++++++++++
 1 files changed, 41 insertions(+), 0 deletions(-)
 create mode 100755 t/t9152-svn-empty-dirs-after-gc.sh

diff --git a/t/t9152-svn-empty-dirs-after-gc.sh
b/t/t9152-svn-empty-dirs-after-gc.sh
new file mode 100755
index 0000000..9ac6ea9
--- /dev/null
+++ b/t/t9152-svn-empty-dirs-after-gc.sh
@@ -0,0 +1,41 @@
+#!/bin/sh
+#
+# Copyright (c) 2009 Robert Zeh
+
+test_description='git svn creates empty directories, calls git gc,
makes sure they are still empty'
+. ./lib-git-svn.sh
+
+test_expect_success 'initialize repo' '
+	for i in a b c d d/e d/e/f "weird file name"
+	do
+		svn_cmd mkdir -m "mkdir $i" "$svnrepo"/"$i"
+	done
+'
+
+test_expect_success 'clone' 'git svn clone "$svnrepo" cloned'
+
+test_expect_success 'git svn gc runs' '
+	(
+		cd cloned &&
+		git svn gc
+	)
+'
+
+test_expect_success 'git svn mkdirs recreates empty directories after
git svn gc' '
+	(
+		cd cloned &&
+		rm -r * &&
+		git svn mkdirs &&
+		for i in a b c d d/e d/e/f "weird file name"
+		do
+			if ! test -d "$i"
+			then
+				echo >&2 "$i does not exist"
+				exit 1
+			fi
+		done
+	)
+'
+
+
+test_done
-- 
1.6.6.rc3.dirty

Re: [PATCH] git svn: add (failing) test for a git svn gc followed by a git svn mkdirs

[Eric Wong]

Robert Zeh <robert.a.zeh@gmail.com> wrote:
> git svn gc will compress the unhandled.log files that git svn mkdirs reads,
> causing git svn mkdirs to skip directory creation.
> ---
>  t/t9152-svn-empty-dirs-after-gc.sh |   41 ++++++++++++++++++++++++++++++++++++
>  1 files changed, 41 insertions(+), 0 deletions(-)
>  create mode 100755 t/t9152-svn-empty-dirs-after-gc.sh

Hi Robert,

I actually got impatient over the weekend and committed a test case and
fix.  I believe I Cc-ed you on it...  But your test case might be
cleaner, but yes, same things Junio said.

-- 
Eric Wong