* [PATCH] builtin/rebase.c: remove superfluous space in messages
@ 2018-11-30 18:11 Ralf Thielow
2018-11-30 18:52 ` Johannes Schindelin
0 siblings, 1 reply; 2+ messages in thread
From: Ralf Thielow @ 2018-11-30 18:11 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano, Ralf Thielow
Signed-off-by: Ralf Thielow <ralf.thielow@gmail.com>
---
builtin/rebase.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/rebase.c b/builtin/rebase.c
index 5b3e5baec8..a6acba76b4 100644
--- a/builtin/rebase.c
+++ b/builtin/rebase.c
@@ -871,7 +871,7 @@ int cmd_rebase(int argc, const char **argv, const char *prefix)
"them"), REBASE_PRESERVE_MERGES),
OPT_BOOL(0, "rerere-autoupdate",
&options.allow_rerere_autoupdate,
- N_("allow rerere to update index with resolved "
+ N_("allow rerere to update index with resolved "
"conflict")),
OPT_BOOL('k', "keep-empty", &options.keep_empty,
N_("preserve empty commits during rebase")),
@@ -1520,7 +1520,7 @@ int cmd_rebase(int argc, const char **argv, const char *prefix)
*/
strbuf_reset(&msg);
if (!oidcmp(&merge_base, &options.orig_head)) {
- printf(_("Fast-forwarded %s to %s. \n"),
+ printf(_("Fast-forwarded %s to %s.\n"),
branch_name, options.onto_name);
strbuf_addf(&msg, "rebase finished: %s onto %s",
options.head_name ? options.head_name : "detached HEAD",
--
2.20.0.rc1.379.g1dd7ef354c
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] builtin/rebase.c: remove superfluous space in messages
2018-11-30 18:11 [PATCH] builtin/rebase.c: remove superfluous space in messages Ralf Thielow
@ 2018-11-30 18:52 ` Johannes Schindelin
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Schindelin @ 2018-11-30 18:52 UTC (permalink / raw)
To: Ralf Thielow; +Cc: git, Junio C Hamano
Hi Ralf,
On Fri, 30 Nov 2018, Ralf Thielow wrote:
> Signed-off-by: Ralf Thielow <ralf.thielow@gmail.com>
ACK.
The commit message could state that the scripted rebase does not have
those whitespace issues, and that this aligns the built-in rebase with it,
but I won't insist.
Ciao,
Johannes
> ---
> builtin/rebase.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/builtin/rebase.c b/builtin/rebase.c
> index 5b3e5baec8..a6acba76b4 100644
> --- a/builtin/rebase.c
> +++ b/builtin/rebase.c
> @@ -871,7 +871,7 @@ int cmd_rebase(int argc, const char **argv, const char *prefix)
> "them"), REBASE_PRESERVE_MERGES),
> OPT_BOOL(0, "rerere-autoupdate",
> &options.allow_rerere_autoupdate,
> - N_("allow rerere to update index with resolved "
> + N_("allow rerere to update index with resolved "
> "conflict")),
> OPT_BOOL('k', "keep-empty", &options.keep_empty,
> N_("preserve empty commits during rebase")),
> @@ -1520,7 +1520,7 @@ int cmd_rebase(int argc, const char **argv, const char *prefix)
> */
> strbuf_reset(&msg);
> if (!oidcmp(&merge_base, &options.orig_head)) {
> - printf(_("Fast-forwarded %s to %s. \n"),
> + printf(_("Fast-forwarded %s to %s.\n"),
> branch_name, options.onto_name);
> strbuf_addf(&msg, "rebase finished: %s onto %s",
> options.head_name ? options.head_name : "detached HEAD",
> --
> 2.20.0.rc1.379.g1dd7ef354c
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-30 18:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-30 18:11 [PATCH] builtin/rebase.c: remove superfluous space in messages Ralf Thielow
2018-11-30 18:52 ` Johannes Schindelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox