Git development
 help / color / mirror / Atom feed
* [PATCH] docs/gitweb.conf: config variable typo
@ 2018-12-08  0:26 Frank Dana
  2018-12-08  0:45 ` Jonathan Nieder
  0 siblings, 1 reply; 3+ messages in thread
From: Frank Dana @ 2018-12-08  0:26 UTC (permalink / raw)
  To: git

The documentation for the feature 'snapshot' claimed
"This feature can be configured on a per-repository basis via
repository's `gitweb.blame` configuration variable"

Fixed to specify `gitweb.snapshot` as the variable name.
---
 Documentation/gitweb.conf.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/gitweb.conf.txt b/Documentation/gitweb.conf.txt
index c0a326e3883c3..40c9563ef67af 100644
--- a/Documentation/gitweb.conf.txt
+++ b/Documentation/gitweb.conf.txt
@@ -684,7 +684,7 @@ compressed tar archive) and "zip"; please consult gitweb sources for
 a definitive list.  By default only "tgz" is offered.
 +
 This feature can be configured on a per-repository basis via
-repository's `gitweb.blame` configuration variable, which contains
+repository's `gitweb.snapshot` configuration variable, which contains
 a comma separated list of formats or "none" to disable snapshots.
 Unknown values are ignored.
 

--
https://github.com/git/git/pull/562

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] docs/gitweb.conf: config variable typo
  2018-12-08  0:26 [PATCH] docs/gitweb.conf: config variable typo Frank Dana
@ 2018-12-08  0:45 ` Jonathan Nieder
  2018-12-08  0:48   ` FeRD
  0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Nieder @ 2018-12-08  0:45 UTC (permalink / raw)
  To: Frank Dana; +Cc: git

Hi,

Frank Dana wrote:

> The documentation for the feature 'snapshot' claimed
> "This feature can be configured on a per-repository basis via
> repository's `gitweb.blame` configuration variable"
>
> Fixed to specify `gitweb.snapshot` as the variable name.
> ---
>  Documentation/gitweb.conf.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for fixing it.  May we forge your sign-off?  See
Documentation/SubmittingPatches section "Certify your work" for what
this means.

Sincerely,
Jonathan

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] docs/gitweb.conf: config variable typo
  2018-12-08  0:45 ` Jonathan Nieder
@ 2018-12-08  0:48   ` FeRD
  0 siblings, 0 replies; 3+ messages in thread
From: FeRD @ 2018-12-08  0:48 UTC (permalink / raw)
  To: jrnieder; +Cc: git

On Fri, Dec 7, 2018 at 7:45 PM Jonathan Nieder <jrnieder@gmail.com> wrote:
>
>
> Thanks for fixing it.  May we forge your sign-off?

Yes please, guess I didn't read far enough down that document. My apologies.
Consider the previous patch email:

Signed-off-by: FeRD (Frank Dana) <ferdnyc@gmail.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-12-08  0:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-08  0:26 [PATCH] docs/gitweb.conf: config variable typo Frank Dana
2018-12-08  0:45 ` Jonathan Nieder
2018-12-08  0:48   ` FeRD

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox