From: Trieu Huynh <vikingtc4@gmail.com>
To: git@vger.kernel.org
Cc: Trieu Huynh <vikingtc4@gmail.com>
Subject: [GSoC PATCH 11/16] t3903: avoid suppressing git's exit code
Date: Sun, 29 Mar 2026 05:02:50 +0900 [thread overview]
Message-ID: <20260328200255.247759-12-vikingtc4@gmail.com> (raw)
In-Reply-To: <20260328200255.247759-1-vikingtc4@gmail.com>
Update t3903-stash.sh to redirect git-cmds output to a temporary
file instead of piping it directly to not hide the exit code
of git commands behind pipes, as a crash in git might go
unnoticed.
Signed-off-by: Trieu Huynh <vikingtc4@gmail.com>
---
t/t3903-stash.sh | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh
index 70879941c2..b67cf23fbb 100755
--- a/t/t3903-stash.sh
+++ b/t/t3903-stash.sh
@@ -962,7 +962,8 @@ test_expect_success 'store updates stash ref and reflog' '
test_path_is_missing bazzy &&
git stash store -m quuxery $STASH_ID &&
test $(git rev-parse stash) = $STASH_ID &&
- git reflog --format=%H stash| grep $STASH_ID &&
+ git reflog --format=%H stash >actual &&
+ test_grep "$STASH_ID" actual &&
git stash pop &&
grep quux bazzy
'
@@ -976,7 +977,7 @@ test_expect_success 'handle stash specification with spaces' '
echo cow >file &&
git stash &&
git stash apply "stash@{$stamp}" &&
- grep pig file
+ test_grep pig file
'
test_expect_success 'setup stash with index and worktree changes' '
--
2.43.0
next prev parent reply other threads:[~2026-03-28 20:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-28 20:02 [GSoC PATCH 00/16] Microproject: avoid suppressing git's exit code Trieu Huynh
2026-03-28 20:02 ` [GSoC PATCH 01/16] t7004: " Trieu Huynh
2026-03-28 20:02 ` [GSoC PATCH 02/16] t6423: " Trieu Huynh
2026-03-28 20:02 ` [GSoC PATCH 03/16] t6411: " Trieu Huynh
2026-03-28 20:02 ` [GSoC PATCH 04/16] t6101: " Trieu Huynh
2026-03-28 20:02 ` [GSoC PATCH 05/16] t6006: " Trieu Huynh
2026-03-28 20:02 ` [GSoC PATCH 06/16] t5304: " Trieu Huynh
2026-03-28 20:02 ` [GSoC PATCH 07/16] t4153: " Trieu Huynh
2026-03-29 15:59 ` Tian Yuchen
2026-03-28 20:02 ` [GSoC PATCH 08/16] t4150: " Trieu Huynh
2026-03-28 20:02 ` [GSoC PATCH 09/16] t4140: " Trieu Huynh
2026-03-28 20:02 ` [GSoC PATCH 10/16] t4039: " Trieu Huynh
2026-03-28 20:02 ` Trieu Huynh [this message]
2026-03-29 16:14 ` [GSoC PATCH 11/16] t3903: " Tian Yuchen
2026-03-28 20:02 ` [GSoC PATCH 12/16] t3701: " Trieu Huynh
2026-03-28 20:02 ` [GSoC PATCH 13/16] t3412: " Trieu Huynh
2026-03-28 20:02 ` [GSoC PATCH 14/16] t1400: " Trieu Huynh
2026-03-28 20:02 ` [GSoC PATCH 15/16] t0100: " Trieu Huynh
2026-03-28 20:02 ` [GSoC PATCH 16/16] t2206: " Trieu Huynh
2026-03-29 0:44 ` [GSoC PATCH 00/16] Microproject: " Junio C Hamano
2026-03-29 12:59 ` Trieu Huynh
2026-03-30 9:51 ` Karthik Nayak
2026-03-30 15:00 ` Junio C Hamano
2026-03-30 18:50 ` Trieu Huynh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260328200255.247759-12-vikingtc4@gmail.com \
--to=vikingtc4@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox