Git development
 help / color / mirror / Atom feed
From: Trieu Huynh <vikingtc4@gmail.com>
To: git@vger.kernel.org
Cc: Trieu Huynh <vikingtc4@gmail.com>
Subject: [GSoC PATCH 12/16] t3701: avoid suppressing git's exit code
Date: Sun, 29 Mar 2026 05:02:51 +0900	[thread overview]
Message-ID: <20260328200255.247759-13-vikingtc4@gmail.com> (raw)
In-Reply-To: <20260328200255.247759-1-vikingtc4@gmail.com>

Update t3701-add-interactive.sh to redirect git-cmds output
to a temporary file instead of piping it directly to not hide
the exit code of git commands behind pipes, as a crash in git
might go unnoticed.

Signed-off-by: Trieu Huynh <vikingtc4@gmail.com>
---
 t/t3701-add-interactive.sh | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/t/t3701-add-interactive.sh b/t/t3701-add-interactive.sh
index 6e120a4001..a07db3b1aa 100755
--- a/t/t3701-add-interactive.sh
+++ b/t/t3701-add-interactive.sh
@@ -293,8 +293,10 @@ test_expect_success FILEMODE 'patch does not affect mode' '
 	echo content >>file &&
 	chmod +x file &&
 	printf "n\\ny\\n" | git add -p &&
-	git show :file | grep content &&
-	git diff file | grep "new mode"
+	git show :file >actual &&
+	test_grep content actual &&
+	git diff file >actual &&
+	test_grep "new mode" actual
 '
 
 test_expect_success FILEMODE 'stage mode but not hunk' '
@@ -302,8 +304,10 @@ test_expect_success FILEMODE 'stage mode but not hunk' '
 	echo content >>file &&
 	chmod +x file &&
 	printf "y\\nn\\n" | git add -p &&
-	git diff --cached file | grep "new mode" &&
-	git diff          file | grep "+content"
+	git diff --cached file >actual &&
+	test_grep "new mode" actual &&
+	git diff          file >actual &&
+	test_grep "+content" actual
 '
 
 
-- 
2.43.0


  parent reply	other threads:[~2026-03-28 20:03 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-28 20:02 [GSoC PATCH 00/16] Microproject: avoid suppressing git's exit code Trieu Huynh
2026-03-28 20:02 ` [GSoC PATCH 01/16] t7004: " Trieu Huynh
2026-03-28 20:02 ` [GSoC PATCH 02/16] t6423: " Trieu Huynh
2026-03-28 20:02 ` [GSoC PATCH 03/16] t6411: " Trieu Huynh
2026-03-28 20:02 ` [GSoC PATCH 04/16] t6101: " Trieu Huynh
2026-03-28 20:02 ` [GSoC PATCH 05/16] t6006: " Trieu Huynh
2026-03-28 20:02 ` [GSoC PATCH 06/16] t5304: " Trieu Huynh
2026-03-28 20:02 ` [GSoC PATCH 07/16] t4153: " Trieu Huynh
2026-03-29 15:59   ` Tian Yuchen
2026-03-28 20:02 ` [GSoC PATCH 08/16] t4150: " Trieu Huynh
2026-03-28 20:02 ` [GSoC PATCH 09/16] t4140: " Trieu Huynh
2026-03-28 20:02 ` [GSoC PATCH 10/16] t4039: " Trieu Huynh
2026-03-28 20:02 ` [GSoC PATCH 11/16] t3903: " Trieu Huynh
2026-03-29 16:14   ` Tian Yuchen
2026-03-28 20:02 ` Trieu Huynh [this message]
2026-03-28 20:02 ` [GSoC PATCH 13/16] t3412: " Trieu Huynh
2026-03-28 20:02 ` [GSoC PATCH 14/16] t1400: " Trieu Huynh
2026-03-28 20:02 ` [GSoC PATCH 15/16] t0100: " Trieu Huynh
2026-03-28 20:02 ` [GSoC PATCH 16/16] t2206: " Trieu Huynh
2026-03-29  0:44 ` [GSoC PATCH 00/16] Microproject: " Junio C Hamano
2026-03-29 12:59   ` Trieu Huynh
2026-03-30  9:51     ` Karthik Nayak
2026-03-30 15:00     ` Junio C Hamano
2026-03-30 18:50       ` Trieu Huynh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260328200255.247759-13-vikingtc4@gmail.com \
    --to=vikingtc4@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox