From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Elijah Newren <newren@gmail.com>,
"Raymond E. Pasco" <ray@ameretat.dev>,
git@vger.kernel.org
Subject: Re: [WIP PATCH] fast-export: emit deletions first
Date: Mon, 6 Apr 2026 17:29:37 -0400 [thread overview]
Message-ID: <20260406212937.GA30202@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqo6jwau34.fsf@gitster.g>
On Mon, Apr 06, 2026 at 10:15:27AM -0700, Junio C Hamano wrote:
> In any case, it is a bit surprising that fast-export survived this
> long without having encountering the problem you are solving. I
> wonder if fast-import handles such an output with some smart to
> avoid the issue?
I think it has come up a few times, but we never actually applied a fix:
2015: https://lore.kernel.org/git/alpine.DEB.2.10.1508191532330.31851@buzzword-bingo.mit.edu/
2017: https://lore.kernel.org/git/1493079137-1838-1-git-send-email-miguel.torroja@gmail.com/
2023: https://lore.kernel.org/git/BBB169A5-0665-47C9-819B-6409A22AB699@lanl.gov/
Looks like discussion got hung up on ordering other types of
modifications, like renames (which can actually have cycles). But I
don't see anything to contradict the view that putting deletions first
solves real problems and would not harm anything. And the answer to "it
hurts to fast-export with renames" is probably "don't do it".
It's also possible that sorting should be the responsibility of the
receiver. I.e., should fast-import see:
M 100644 :blob_label a/b
D a
and figure it out? Or maybe we want both (to help other consumers of
fast-export, but also to help fast-import when consuming output of other
sources).
-Peff
next prev parent reply other threads:[~2026-04-06 21:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-06 6:36 [WIP PATCH] fast-export: emit deletions first Raymond E. Pasco
2026-04-06 17:15 ` Junio C Hamano
2026-04-06 21:29 ` Jeff King [this message]
2026-04-06 21:44 ` Elijah Newren
2026-04-07 4:24 ` Jeff King
2026-04-07 21:28 ` Raymond E. Pasco
2026-04-07 1:12 ` Raymond E. Pasco
2026-04-07 4:26 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260406212937.GA30202@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
--cc=ray@ameretat.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox