Git development
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Elijah Newren <newren@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	"Raymond E. Pasco" <ray@ameretat.dev>,
	git@vger.kernel.org
Subject: Re: [WIP PATCH] fast-export: emit deletions first
Date: Tue, 7 Apr 2026 00:24:32 -0400	[thread overview]
Message-ID: <20260407042432.GA627864@coredump.intra.peff.net> (raw)
In-Reply-To: <CABPp-BHhXQc-s8rF1n+AQ0VodX2KuiahcAOcg2msR1eZrUSsCA@mail.gmail.com>

On Mon, Apr 06, 2026 at 02:44:05PM -0700, Elijah Newren wrote:

> > It's also possible that sorting should be the responsibility of the
> > receiver. I.e., should fast-import see:
> >
> >   M 100644 :blob_label a/b
> >   D a
> >
> > and figure it out? Or maybe we want both (to help other consumers of
> > fast-export, but also to help fast-import when consuming output of other
> > sources).
> 
> Would re-ordering on fast-import's side introduce bugs or violate
> user's assumptions?  Right now, fast-import has no check to prevent
> more than one command for the same pathname being given, and has a
> last-entry-wins ruling.  Thus filemodify PATH followed by filedelete
> PATH gives different results than reversing the order.  Most probably
> wouldn't care or want to ever do that, but I could see it as a way of
> allowing you to change your mind in the stream and override an earlier
> directive you sent.

Hmm, good point. It probably is better to leave the reading side as-is,
then, to be on the safe side.

-Peff

  reply	other threads:[~2026-04-07  4:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-06  6:36 [WIP PATCH] fast-export: emit deletions first Raymond E. Pasco
2026-04-06 17:15 ` Junio C Hamano
2026-04-06 21:29   ` Jeff King
2026-04-06 21:44     ` Elijah Newren
2026-04-07  4:24       ` Jeff King [this message]
2026-04-07 21:28       ` Raymond E. Pasco
2026-04-07  1:12   ` Raymond E. Pasco
2026-04-07  4:26     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260407042432.GA627864@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=newren@gmail.com \
    --cc=ray@ameretat.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox