Git development
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] gitglossary: fix indentation of sub-lists
Date: Sun, 12 Apr 2026 15:56:56 -0400	[thread overview]
Message-ID: <20260412195656.GA1691477@coredump.intra.peff.net> (raw)
In-Reply-To: <ee8d43cc-c38b-4a55-8237-94f92034d62f@app.fastmail.com>

On Sun, Apr 12, 2026 at 11:10:34AM +0200, Kristoffer Haugsbakk wrote:

> > But asciidoc being asciidoc, of course that is not the end of the story.
> 
> Ouch.
> 
> > That technique works fine for the "glob" and "attr" lists in this patch,
> > but under the "refs" item it works for only 1 of the 2 lists! I can't
> > figure out why, and this may be an asciidoctor bug. But we can work
> 
> You mention “asciidoc being asciidoc” but here it seems to be
> about Asciidoctor?

It is. I meant "asciidoc the language", not "asciidoc the tool". I
didn't want to be too harsh on asciidoctor specifically. I think in
aggregate the pain comes equally from both tools. ;)

> > So using the extra blank line for the first two instances, and "--"
> > markers for the second two, this patch produces identical output from
> > "doc-diff HEAD^ HEAD" for both --asciidoctor and --ascii modes.
> 
> Nit: s/--ascii/--asciidoc/

Oops, yes.

-Peff

      reply	other threads:[~2026-04-12 19:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-11 19:06 [PATCH] gitglossary: fix indentation of sub-lists Jeff King
2026-04-11 20:34 ` Kristoffer Haugsbakk
2026-04-11 20:47   ` Kristoffer Haugsbakk
2026-04-11 21:42     ` Jeff King
2026-04-11 21:55       ` [PATCH v2] " Jeff King
2026-04-12  9:10         ` Kristoffer Haugsbakk
2026-04-12 19:56           ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260412195656.GA1691477@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=kristofferhaugsbakk@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox