From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Derrick Stolee <stolee@gmail.com>
Subject: Re: [PATCH] t5551: "GIT_TEST_LONG=Yes make test" is broken
Date: Fri, 8 May 2026 10:03:55 -0400 [thread overview]
Message-ID: <20260508140355.GA709299@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqqznmeaco.fsf@gitster.g>
On Fri, May 08, 2026 at 02:31:03PM +0900, Junio C Hamano wrote:
> The "test_expect_success 'tag following always works over v0 http'"
> test in t5551 fails when it tries to run "git init tags", but this
> happens only when EXPENSIVE test is allowed to run.
>
> This is because the step tries to create a repository with "git init
> tags" but the EXPENSIVE test that runs way before it creates and
> leaves around a temporary file "tags". Have the EXPENSIVE test
> clean it up after itself.
I wondered how and when this broke, but it looks like it has been since
2024 when the later v0 test was added. And it looks like I am the
culprit for both the EXPENSIVE test adding the "tags" file and the v0
test assuming the path is available. :)
Anyway, this seems like the obviously correct solution.
-Peff
prev parent reply other threads:[~2026-05-08 14:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 5:31 [PATCH] t5551: "GIT_TEST_LONG=Yes make test" is broken Junio C Hamano
2026-05-08 14:03 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260508140355.GA709299@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox