From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: Derrick Stolee <stolee@gmail.com>
Subject: [PATCH] t5551: "GIT_TEST_LONG=Yes make test" is broken
Date: Fri, 08 May 2026 14:31:03 +0900 [thread overview]
Message-ID: <xmqqqznmeaco.fsf@gitster.g> (raw)
The "test_expect_success 'tag following always works over v0 http'"
test in t5551 fails when it tries to run "git init tags", but this
happens only when EXPENSIVE test is allowed to run.
This is because the step tries to create a repository with "git init
tags" but the EXPENSIVE test that runs way before it creates and
leaves around a temporary file "tags". Have the EXPENSIVE test
clean it up after itself.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
* As we should give individual contributors a stable base, I have
identified tests that fail with EXPENSIVE enabled in "master".
With this fixed, we should add GIT_TEST_LONG=YesPlease to the CI
jobs run upon PRs are created by contributors.
t/t5551-http-fetch-smart.sh | 1 +
1 file changed, 1 insertion(+)
diff --git c/t/t5551-http-fetch-smart.sh w/t/t5551-http-fetch-smart.sh
index a26b6c2844..e236e526f0 100755
--- c/t/t5551-http-fetch-smart.sh
+++ w/t/t5551-http-fetch-smart.sh
@@ -481,6 +481,7 @@ test_expect_success 'test allowanysha1inwant with unreachable' '
'
test_expect_success EXPENSIVE 'http can handle enormous ref negotiation' '
+ test_when_finished "rm -f tags" &&
(
cd "$HTTPD_DOCUMENT_ROOT_PATH/repo.git" &&
create_tags 2001 50000
next reply other threads:[~2026-05-08 5:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 5:31 Junio C Hamano [this message]
2026-05-08 14:03 ` [PATCH] t5551: "GIT_TEST_LONG=Yes make test" is broken Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqqznmeaco.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox