Re: [PATCH v2 1/4] t1517: skip svn tests if svn is not installed

[Jeff King <peff@peff.net>]

On Wed, Jul 01, 2026 at 09:24:39PM +0000, brian m. carlson wrote:

> +test_lazy_prereq SVN '
> +	test_have_prereq PERL && test -n "$NO_SVN_TESTS" && perl -w -e "
> +		use SVN::Core;
> +		use SVN::Repos;
> +		\$SVN::Core::VERSION gt '1.1.0' or exit(42);
> +	"
> +'

The single-quotes in your inline perl will be interpreted as ending (and
restarting) the lazy-prereq snippet. So you actually get a bare:

  $SVN::Core::VERSION gt 1.1.0 or exit(42);

fed to perl (no quotes around 1.1.0). We sometimes catch these cases
automatically it results in an extra argument to test_expect_success,
etc. But here you are unlucky enough that it does not (and anyway, we do
not seem to have the same safety check for test_lazy_prereq; we'd just
ignore the extra arguments).

And of course being perl, it doesn't complain. I'm not sure how it is
interpreted, but I doubt the use of "gt" is right. My version of
SVN::Core is 1.14.5, which is (correctly) more than "1.1.0", but is
(incorrect) not more than "1.2.0".

I think the "gt" bug is inherited from lib-git-svn.sh (unless I'm just
holding it wrong), but the single-quote one is new (it happens at the
top-level in the original).

-Peff