Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,  git@vger.kernel.org
Subject: Re: [PATCH v2 1/4] t1517: skip svn tests if svn is not installed
Date: Fri, 03 Jul 2026 13:36:37 -0700	[thread overview]
Message-ID: <xmqq33xzize2.fsf@gitster.g> (raw)
In-Reply-To: <20260702053724.GA3437623@coredump.intra.peff.net> (Jeff King's message of "Thu, 2 Jul 2026 01:37:24 -0400")

Jeff King <peff@peff.net> writes:

> fed to perl (no quotes around 1.1.0). We sometimes catch these cases
> automatically it results in an extra argument to test_expect_success,
> etc. But here you are unlucky enough that it does not (and anyway, we do
> not seem to have the same safety check for test_lazy_prereq; we'd just
> ignore the extra arguments).
>
> And of course being perl, it doesn't complain. I'm not sure how it is
> interpreted,

I happen to know ;-).

When you have more than two sequences of digits separated by dot,
like IP address 192.168.1.1, you are telling Perl to interpret the
sequence as a string, each byte of it is the number denoted by these
digits.  I believe this was invented primarily for IP addresses, but
it does not have to be just four digits.  To wit:

    $ perl -e 'print 65.66.67;'
    ABC
    $ perl -e 'print 65.66.67.68.69;'
    ABCDE

Of course, 65.66 is not AB, but a floating-point number that is
between integers 65 and 66:

    $ perl -e 'print 65.66;'
    65.66

> but I doubt the use of "gt" is right.

True.

  reply	other threads:[~2026-07-03 20:36 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-15  0:52 Unexpected exit code for --help with rev-parse --parseopt brian m. carlson
2026-03-15  3:14 ` Jeff King
2026-03-15 16:59   ` brian m. carlson
2026-03-15 18:16     ` Jeff King
2026-03-16 22:07 ` [PATCH] rev-parse: have --parseopt callers exit 0 on --help brian m. carlson
2026-03-17  0:47   ` Junio C Hamano
2026-03-17 11:59     ` brian m. carlson
2026-03-17 14:55       ` Jeff King
2026-03-17 15:07         ` Jeff King
2026-03-17 17:06         ` Junio C Hamano
2026-03-17 18:44           ` Jeff King
2026-03-18  0:24             ` brian m. carlson
2026-03-18  1:22               ` Jeff King
2026-03-18  2:45                 ` Junio C Hamano
2026-07-01 21:24   ` [PATCH v2 0/4] rev-parse: " brian m. carlson
2026-07-01 21:24     ` [PATCH v2 1/4] t1517: skip svn tests if svn is not installed brian m. carlson
2026-07-01 22:10       ` Junio C Hamano
2026-07-01 22:27       ` Junio C Hamano
2026-07-02 14:47         ` [PATCH v2 1/4] t1517: skip svn tests if svn is not installed2sy brian m. carlson
2026-07-02  5:37       ` [PATCH v2 1/4] t1517: skip svn tests if svn is not installed Jeff King
2026-07-03 20:36         ` Junio C Hamano [this message]
2026-07-04  4:47           ` Jeff King
2026-07-01 21:24     ` [PATCH v2 2/4] parse-options: add a separate case for help output on error brian m. carlson
2026-07-02  8:38       ` Jeff King
2026-07-01 21:24     ` [PATCH v2 3/4] rev-parse: have --parseopt callers exit 0 on --help brian m. carlson
2026-07-01 22:16       ` Junio C Hamano
2026-07-01 21:24     ` [PATCH v2 4/4] parse-options: exit 0 on -h brian m. carlson
2026-07-01 22:06     ` [PATCH v2 0/4] rev-parse: exit 0 on --help Junio C Hamano
2026-07-02  8:45       ` Jeff King
2026-07-03 20:38         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq33xzize2.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox