From: Tian Yuchen <cat@malon.dev>
To: git@vger.kernel.org
Cc: pabloosabaterr@gmail.com, cirnovskyv@gmail.com,
szeder.dev@gmail.com, Tian Yuchen <cat@malon.dev>,
Christian Couder <christian.couder@gmail.com>,
Ayush Chandekar <ayu.chandekar@gmail.com>,
Olamide Caleb Bello <belkid98@gmail.com>
Subject: [PATCH v12 10/10] repository: adjust the comment of config_values_private_
Date: Tue, 14 Jul 2026 11:25:25 +0800 [thread overview]
Message-ID: <20260714032525.1611141-11-cat@malon.dev> (raw)
In-Reply-To: <20260714032525.1611141-1-cat@malon.dev>
The configurations in 'struct config_values_private_' are not all
parsed in 'git_default_config()'. For example, 'pager_program' is
now parsed in 'pager.c'. Therefore, update the comment.
Mentored-by: Christian Couder <christian.couder@gmail.com>
Mentored-by: Ayush Chandekar <ayu.chandekar@gmail.com>
Mentored-by: Olamide Caleb Bello <belkid98@gmail.com>
Signed-off-by: Tian Yuchen <cat@malon.dev>
---
repository.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/repository.h b/repository.h
index 36e2db2633..9093e6af93 100644
--- a/repository.h
+++ b/repository.h
@@ -152,7 +152,7 @@ struct repository {
/* Repository's compatibility hash algorithm. */
const struct git_hash_algo *compat_hash_algo;
- /* Repository's config values parsed by git_default_config() */
+ /* Repository-specific configuration values. */
struct repo_config_values config_values_private_;
/* Repository's reference storage format, as serialized on disk. */
--
2.43.0
prev parent reply other threads:[~2026-07-14 3:26 UTC|newest]
Thread overview: 113+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-26 7:50 [PATCH v2 0/2] environment: move excludes_file into repo_config_values Tian Yuchen
2026-06-26 7:50 ` [PATCH v2 1/2] dir: encapsulate excludes_file lazy-load Tian Yuchen
2026-06-26 21:14 ` SZEDER Gábor
2026-06-26 21:45 ` Junio C Hamano
2026-06-27 14:13 ` Tian Yuchen
2026-06-26 7:50 ` [PATCH v2 2/2] environment: move excludes_file into repo_config_values Tian Yuchen
2026-06-26 15:43 ` Junio C Hamano
2026-06-26 19:12 ` Junio C Hamano
2026-06-27 14:10 ` Tian Yuchen
2026-06-26 15:42 ` [PATCH v2 0/2] " Junio C Hamano
2026-06-27 13:56 ` Tian Yuchen
2026-06-27 16:08 ` [PATCH v4 0/1] " Tian Yuchen
2026-06-27 16:08 ` [PATCH v4 1/1] " Tian Yuchen
2026-06-27 16:10 ` Tian Yuchen
2026-06-27 20:47 ` Junio C Hamano
2026-06-28 3:19 ` Tian Yuchen
2026-06-28 3:38 ` Tian Yuchen
2026-06-28 8:40 ` Junio C Hamano
2026-06-28 12:58 ` Tian Yuchen
2026-06-29 6:03 ` Christian Couder
2026-06-29 14:47 ` Junio C Hamano
2026-06-30 16:20 ` Tian Yuchen
2026-07-01 18:14 ` Tian Yuchen
2026-06-30 16:44 ` [PATCH v5 0/1] " Tian Yuchen
2026-06-30 16:44 ` [PATCH v5 1/1] " Tian Yuchen
2026-07-01 18:08 ` [PATCH v6 0/1] " Tian Yuchen
2026-07-01 18:08 ` [PATCH v6 1/1] " Tian Yuchen
2026-07-06 14:25 ` [PATCH v7 0/9] migrate more variables " Tian Yuchen
2026-07-06 14:25 ` [PATCH v7 1/9] repository: introduce repo_config_values_clear() Tian Yuchen
2026-07-06 14:25 ` [PATCH v7 2/9] environment: move excludes_file into repo_config_values Tian Yuchen
2026-07-06 14:25 ` [PATCH v7 3/9] environment: move editor_program " Tian Yuchen
2026-07-11 19:05 ` Pablo Sabater
2026-07-11 19:38 ` Pablo Sabater
2026-07-06 14:25 ` [PATCH v7 4/9] environment: move pager_program " Tian Yuchen
2026-07-06 17:38 ` Junio C Hamano
2026-07-06 14:25 ` [PATCH v7 5/9] environment: move askpass_program " Tian Yuchen
2026-07-06 14:25 ` [PATCH v7 6/9] environment: migrate apply_default_whitespace and apply_default_ignorewhitespace Tian Yuchen
2026-07-06 14:25 ` [PATCH v7 7/9] environment: move push_default into repo_config_values Tian Yuchen
2026-07-06 14:25 ` [PATCH v7 8/9] environment: move autorebase " Tian Yuchen
2026-07-06 14:25 ` [PATCH v7 9/9] environment: move object_creation_mode " Tian Yuchen
2026-07-08 16:02 ` [PATCH v8 0/9] migrate more variables " Tian Yuchen
2026-07-08 16:02 ` [PATCH v8 1/9] repository: introduce repo_config_values_clear() Tian Yuchen
2026-07-08 16:02 ` [PATCH v8 2/9] environment: move excludes_file into repo_config_values Tian Yuchen
2026-07-08 16:02 ` [PATCH v8 3/9] environment: move editor_program " Tian Yuchen
2026-07-08 16:02 ` [PATCH v8 4/9] environment: move pager_program " Tian Yuchen
2026-07-09 3:53 ` Junio C Hamano
2026-07-09 16:12 ` Tian Yuchen
2026-07-09 16:41 ` Junio C Hamano
2026-07-08 16:02 ` [PATCH v8 5/9] environment: move askpass_program " Tian Yuchen
2026-07-08 16:02 ` [PATCH v8 6/9] environment: migrate apply_default_whitespace and apply_default_ignorewhitespace Tian Yuchen
2026-07-08 16:02 ` [PATCH v8 7/9] environment: move push_default into repo_config_values Tian Yuchen
2026-07-08 16:02 ` [PATCH v8 8/9] environment: move autorebase " Tian Yuchen
2026-07-08 16:03 ` [PATCH v8 9/9] environment: move object_creation_mode " Tian Yuchen
2026-07-09 16:11 ` [PATCH v9 0/9] migrate more variables " Tian Yuchen
2026-07-09 16:11 ` [PATCH v9 1/9] repository: introduce repo_config_values_clear() Tian Yuchen
2026-07-11 17:21 ` Pablo Sabater
2026-07-11 18:35 ` Tian Yuchen
2026-07-12 9:28 ` Pablo Sabater
2026-07-12 10:44 ` Tian Yuchen
2026-07-09 16:11 ` [PATCH v9 2/9] environment: move excludes_file into repo_config_values Tian Yuchen
2026-07-11 18:21 ` Pablo Sabater
2026-07-12 10:08 ` Tian Yuchen
2026-07-09 16:11 ` [PATCH v9 3/9] environment: move editor_program " Tian Yuchen
2026-07-11 19:30 ` Pablo Sabater
2026-07-09 16:11 ` [PATCH v9 4/9] environment: move pager_program " Tian Yuchen
2026-07-09 16:11 ` [PATCH v9 5/9] environment: move askpass_program " Tian Yuchen
2026-07-09 16:11 ` [PATCH v9 6/9] environment: migrate apply_default_whitespace and apply_default_ignorewhitespace Tian Yuchen
2026-07-09 16:11 ` [PATCH v9 7/9] environment: move push_default into repo_config_values Tian Yuchen
2026-07-09 16:11 ` [PATCH v9 8/9] environment: move autorebase " Tian Yuchen
2026-07-09 16:11 ` [PATCH v9 9/9] environment: move object_creation_mode " Tian Yuchen
2026-07-11 15:24 ` [PATCH v9 0/9] migrate more variables " Pablo Sabater
2026-07-11 16:11 ` Tian Yuchen
2026-07-11 21:10 ` Junio C Hamano
2026-07-11 21:06 ` Junio C Hamano
2026-07-12 9:34 ` Pablo Sabater
2026-07-12 11:17 ` [PATCH v10 " Tian Yuchen
2026-07-12 11:17 ` [PATCH v10 1/9] repository: introduce repo_config_values_clear() Tian Yuchen
2026-07-12 11:17 ` [PATCH v10 2/9] environment: move excludes_file into repo_config_values Tian Yuchen
2026-07-12 11:17 ` [PATCH v10 3/9] environment: move editor_program " Tian Yuchen
2026-07-12 11:17 ` [PATCH v10 4/9] environment: move pager_program " Tian Yuchen
2026-07-12 14:12 ` Pablo Sabater
2026-07-12 16:54 ` Tian Yuchen
2026-07-12 15:36 ` Junio C Hamano
2026-07-12 16:58 ` Tian Yuchen
2026-07-12 11:17 ` [PATCH v10 5/9] environment: move askpass_program " Tian Yuchen
2026-07-12 14:31 ` Pablo Sabater
2026-07-12 15:47 ` Junio C Hamano
2026-07-12 11:17 ` [PATCH v10 6/9] environment: migrate apply_default_whitespace and apply_default_ignorewhitespace Tian Yuchen
2026-07-12 15:04 ` Pablo Sabater
2026-07-12 11:17 ` [PATCH v10 7/9] environment: move push_default into repo_config_values Tian Yuchen
2026-07-12 15:49 ` Pablo Sabater
2026-07-12 11:17 ` [PATCH v10 8/9] environment: move autorebase " Tian Yuchen
2026-07-12 11:17 ` [PATCH v10 9/9] environment: move object_creation_mode " Tian Yuchen
2026-07-13 3:57 ` [PATCH v11 00/10] migrate more variables " Tian Yuchen
2026-07-13 3:57 ` [PATCH v11 01/10] repository: introduce repo_config_values_clear() Tian Yuchen
2026-07-13 3:57 ` [PATCH v11 02/10] environment: move excludes_file into repo_config_values Tian Yuchen
2026-07-13 3:57 ` [PATCH v11 03/10] environment: move editor_program " Tian Yuchen
2026-07-13 3:57 ` [PATCH v11 04/10] environment: move pager_program " Tian Yuchen
2026-07-13 3:57 ` [PATCH v11 05/10] environment: move askpass_program " Tian Yuchen
2026-07-13 3:57 ` [PATCH v11 06/10] environment: migrate apply_default_whitespace and apply_default_ignorewhitespace Tian Yuchen
2026-07-13 16:39 ` Junio C Hamano
2026-07-14 3:19 ` Tian Yuchen
2026-07-14 3:25 ` [PATCH v12 00/10] migrate more variables into repo_config_values Tian Yuchen
2026-07-14 3:25 ` [PATCH v12 01/10] repository: introduce repo_config_values_clear() Tian Yuchen
2026-07-14 3:25 ` [PATCH v12 02/10] environment: move excludes_file into repo_config_values Tian Yuchen
2026-07-14 3:25 ` [PATCH v12 03/10] environment: move editor_program " Tian Yuchen
2026-07-14 3:25 ` [PATCH v12 04/10] environment: move pager_program " Tian Yuchen
2026-07-14 3:25 ` [PATCH v12 05/10] environment: move askpass_program " Tian Yuchen
2026-07-14 3:25 ` [PATCH v12 06/10] environment: migrate apply_default_whitespace and apply_default_ignorewhitespace Tian Yuchen
2026-07-14 3:25 ` [PATCH v12 07/10] environment: move push_default into repo_config_values Tian Yuchen
2026-07-14 3:25 ` [PATCH v12 08/10] environment: move autorebase " Tian Yuchen
2026-07-14 3:25 ` [PATCH v12 09/10] environment: move object_creation_mode " Tian Yuchen
2026-07-14 3:25 ` Tian Yuchen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260714032525.1611141-11-cat@malon.dev \
--to=cat@malon.dev \
--cc=ayu.chandekar@gmail.com \
--cc=belkid98@gmail.com \
--cc=christian.couder@gmail.com \
--cc=cirnovskyv@gmail.com \
--cc=git@vger.kernel.org \
--cc=pabloosabaterr@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox