From: Shlok Kulshreshtha <diy2903@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
Shlok Kulshreshtha <diy2903@gmail.com>
Subject: [PATCH v2 0/2] t1100: modernize test script
Date: Tue, 14 Jul 2026 12:46:31 +0530 [thread overview]
Message-ID: <20260714071633.35446-1-diy2903@gmail.com> (raw)
In-Reply-To: <20260713140142.27898-1-diy2903@gmail.com>
This is v2 of the microproject cleaning up
t/t1100-commit-tree-options.sh ("Modernize a test script").
Thanks to Junio for reviewing v1. The only change since v1 is in the
commit message of patch 2/2: it now uses the present tense ("is
created") to describe the current behavior of the script, as suggested.
Patch 1/2 is unchanged.
1/2 converts the tests from the old backslash-continued
test_expect_success style with space-indented bodies to the
modern quoted-body form indented with tabs.
2/2 moves the here-doc that creates "expected" out of the script's
top level and into the existing setup test, so it runs under the
protection of the test harness.
t1100 continues to pass all 5 tests.
Shlok Kulshreshtha (2):
t1100: modernize test style
t1100: move creation of expected output into setup test
t/t1100-commit-tree-options.sh | 59 +++++++++++++++++-----------------
1 file changed, 29 insertions(+), 30 deletions(-)
Range-diff against v1:
1: 45f590f110 = 1: 45f590f110 t1100: modernize test style
2: f74c71c104 ! 2: 36ea70be9d t1100: move creation of expected output into setup test
@@ Metadata
## Commit message ##
t1100: move creation of expected output into setup test
- The "expected" file was created at the top level of the script, outside
+ The "expected" file is created at the top-level of the script, outside
of any test. Code that runs outside of a test is not protected by the
test harness: a failure there is not reported as a test failure and is
easy to miss.
--
2.52.0
next prev parent reply other threads:[~2026-07-14 7:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 14:01 [PATCH 0/2] t1100: modernize test script Shlok Kulshreshtha
2026-07-13 14:01 ` [PATCH 1/2] t1100: modernize test style Shlok Kulshreshtha
2026-07-13 16:30 ` Junio C Hamano
2026-07-14 7:39 ` Patrick Steinhardt
2026-07-13 14:01 ` [PATCH 2/2] t1100: move creation of expected output into setup test Shlok Kulshreshtha
2026-07-13 16:10 ` Junio C Hamano
2026-07-14 7:16 ` Shlok Kulshreshtha [this message]
2026-07-14 7:16 ` [PATCH v2 1/2] t1100: modernize test style Shlok Kulshreshtha
2026-07-14 7:16 ` [PATCH v2 2/2] t1100: move creation of expected output into setup test Shlok Kulshreshtha
2026-07-14 12:20 ` [PATCH v3 0/2] t1100: modernize test script Shlok Kulshreshtha
2026-07-14 12:20 ` [PATCH v3 1/2] t1100: modernize test style Shlok Kulshreshtha
2026-07-14 12:20 ` [PATCH v3 2/2] t1100: move creation of expected output into setup test Shlok Kulshreshtha
2026-07-14 13:56 ` [PATCH v3 0/2] t1100: modernize test script Patrick Steinhardt
2026-07-14 15:34 ` Junio C Hamano
2026-07-14 16:43 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260714071633.35446-1-diy2903@gmail.com \
--to=diy2903@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox