Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Shlok Kulshreshtha <diy2903@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] t1100: modernize test style
Date: Mon, 13 Jul 2026 09:30:21 -0700	[thread overview]
Message-ID: <xmqqpl0qyhr6.fsf@gitster.g> (raw)
In-Reply-To: <20260713140142.27898-2-diy2903@gmail.com> (Shlok Kulshreshtha's message of "Mon, 13 Jul 2026 19:31:40 +0530")

Shlok Kulshreshtha <diy2903@gmail.com> writes:

> The tests in this script use the old style in which the test title and
> body are passed as separate backslash-continued arguments, with bodies
> indented using spaces:
>
>     test_expect_success \
>         'title' \
>         'body'
>
> Convert them to the modern style in which the body is a single-quoted
> block on its own lines, indented with a tab:
>
>     test_expect_success 'title' '
>         body
>     '
>
> This is a style-only change; no test logic is modified.

Cleanly done.  Running "git show -w" on this patch clearly
demonstrates that no code has changed.

Thanks.

  reply	other threads:[~2026-07-13 16:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-13 14:01 [PATCH 0/2] t1100: modernize test script Shlok Kulshreshtha
2026-07-13 14:01 ` [PATCH 1/2] t1100: modernize test style Shlok Kulshreshtha
2026-07-13 16:30   ` Junio C Hamano [this message]
2026-07-14  7:39   ` Patrick Steinhardt
2026-07-13 14:01 ` [PATCH 2/2] t1100: move creation of expected output into setup test Shlok Kulshreshtha
2026-07-13 16:10   ` Junio C Hamano
2026-07-14  7:16 ` [PATCH v2 0/2] t1100: modernize test script Shlok Kulshreshtha
2026-07-14  7:16   ` [PATCH v2 1/2] t1100: modernize test style Shlok Kulshreshtha
2026-07-14  7:16   ` [PATCH v2 2/2] t1100: move creation of expected output into setup test Shlok Kulshreshtha
2026-07-14 12:20   ` [PATCH v3 0/2] t1100: modernize test script Shlok Kulshreshtha
2026-07-14 12:20     ` [PATCH v3 1/2] t1100: modernize test style Shlok Kulshreshtha
2026-07-14 12:20     ` [PATCH v3 2/2] t1100: move creation of expected output into setup test Shlok Kulshreshtha
2026-07-14 13:56     ` [PATCH v3 0/2] t1100: modernize test script Patrick Steinhardt
2026-07-14 15:34       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpl0qyhr6.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=diy2903@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox