Git development
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] trailers: stop recognizing URLs as trailers
Date: Thu, 20 Aug 2026 20:42:48 -0400	[thread overview]
Message-ID: <20260821004248.GA296777@coredump.intra.peff.net> (raw)
In-Reply-To: <c097cc44-3033-4f22-8c48-859de8353f99@app.fastmail.com>

On Thu, Aug 20, 2026 at 04:47:52PM +0200, Kristoffer Haugsbakk wrote:

> > Can somebody summarize the outstanding issues on this topic (if
> > any)?
> 
> I have version 2 ready. The only code change is using `starts_with` like
> Peff mentioned. What I wrote about the changes:

Yep, v2 looks great to me.

-Peff

  reply	other threads:[~2026-08-21  0:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-04 21:27 trailers: --only-trailers normalizes URLs to trailers Kristoffer Haugsbakk
2026-06-09  0:43 ` Jeff King
2026-06-10 14:21   ` Kristoffer Haugsbakk
2026-06-11  6:56     ` Jeff King
2026-06-11  7:03       ` Kristoffer Haugsbakk
2026-08-02 19:57   ` [PATCH] trailers: stop recognizing URLs as trailers kristofferhaugsbakk
2026-08-02 22:36     ` Junio C Hamano
2026-08-03 12:11       ` Kristoffer Haugsbakk
2026-08-03 15:20     ` Jeff King
2026-08-03 15:39       ` Junio C Hamano
2026-08-06 20:17       ` Kristoffer Haugsbakk
2026-08-20 14:38     ` Junio C Hamano
2026-08-20 14:47       ` Kristoffer Haugsbakk
2026-08-21  0:42         ` Jeff King [this message]
2026-08-20 20:00     ` [PATCH v2] " kristofferhaugsbakk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260821004248.GA296777@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kristofferhaugsbakk@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox