Git development
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] ci: fix missing Ruby dependency in "documentation" job
Date: Tue, 1 Sep 2026 04:47:37 -0400	[thread overview]
Message-ID: <20260901084737.GA2973751@coredump.intra.peff.net> (raw)
In-Reply-To: <20260901-b4-pks-ci-fix-documentation-job-v1-1-a8257ee2a9a4@pks.im>

On Tue, Sep 01, 2026 at 10:16:11AM +0200, Patrick Steinhardt wrote:

> Our "documentation" job has recently stopped working with the following
> error:
> 
>   + sudo gem install --version 1.5.8 asciidoctor
>   + gem install --version 1.5.8 asciidoctor
>   ./ci/install-dependencies.sh: 23: gem: not found

Not directly related to your patch but... asciidoctor 1.5.8, really?
That version is 8 years old. Looks like we set that version in
615a6c37e1 (ci: stick with Asciidoctor v1.5.8 for now, 2019-03-29)
due to some issues with the then-new-ish v2.0.0.

But these days I'd guess everybody is using v2.0.x (which seems to work
fine) for local builds. We probably ought to do the same in CI. If we
have to catch issues in one, I'd rather it be the one people are likely
to actually use.

It's possible that we could benefit from building with both in order to
support the older version. But given its age I doubt it's worth it. We
can still take bug fixes if somebody finds a problem, but we don't
necessarily need to spend cycles building every commit with 1.5.8.

-Peff

  parent reply	other threads:[~2026-09-01  8:47 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01  8:16 [PATCH] ci: fix missing Ruby dependency in "documentation" job Patrick Steinhardt
2026-09-01  8:24 ` Toon Claes
2026-09-01  8:36   ` Patrick Steinhardt
2026-09-01  8:47 ` Jeff King [this message]
2026-09-01  8:51   ` Jeff King
2026-09-01 10:41   ` Patrick Steinhardt
2026-09-02  7:11     ` [PATCH 0/2] bump ci asciidoctor version Jeff King
2026-09-02  7:14       ` [PATCH 1/2] ci: drop ALREADY_HAVE_ASCIIDOCTOR variable Jeff King
2026-09-02  7:16       ` [PATCH 2/2] ci: use system asciidoctor Jeff King
2026-09-02  7:55         ` Patrick Steinhardt
2026-09-02  9:01           ` Jeff King
2026-09-02  9:59             ` Patrick Steinhardt
2026-09-05 14:02               ` Jeff King
2026-09-05 15:23                 ` Todd Zullinger
2026-09-11 20:42                   ` Jeff King
2026-09-11 19:52       ` [PATCH (RESEND)] " Tuomas Ahola
2026-09-11 20:38         ` Jeff King
2026-09-11 20:58         ` Junio C Hamano
2026-09-11 21:33           ` Tuomas Ahola
2026-09-11 21:50             ` Junio C Hamano
2026-09-01 17:58   ` [PATCH] ci: fix missing Ruby dependency in "documentation" job Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260901084737.GA2973751@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox