Git development
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Patrick Steinhardt <ps@pks.im>
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Jean-Noël Avila" <jn.avila@free.fr>,
	git@vger.kernel.org
Subject: [PATCH 1/2] ci: drop ALREADY_HAVE_ASCIIDOCTOR variable
Date: Wed, 2 Sep 2026 03:14:09 -0400	[thread overview]
Message-ID: <20260902071409.GA641414@coredump.intra.peff.net> (raw)
In-Reply-To: <20260902071113.GA70165@coredump.intra.peff.net>

Our install-dependencies script avoids installing asciidoctor if the
CI environment claims to have it already. But the only environment which
made use of this was Azure Pipelines, which went away in 6081d3898f (ci:
retire the Azure Pipelines definition, 2020-04-11). So this conditional
was effectively doing nothing. Let's clean it up.

Signed-off-by: Jeff King <peff@peff.net>
---
 ci/install-dependencies.sh | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh
index 502e518077..2f61fbb07c 100755
--- a/ci/install-dependencies.sh
+++ b/ci/install-dependencies.sh
@@ -166,7 +166,6 @@ sparse)
 Documentation)
 	sudo apt-get -q -y install asciidoc xmlto docbook-xsl-ns make ruby
 
-	test -n "$ALREADY_HAVE_ASCIIDOCTOR" ||
 	sudo gem install --version 1.5.8 asciidoctor
 	sudo gem install concurrent-ruby
 	;;
-- 
2.55.0.1074.gcd259ea853


  reply	other threads:[~2026-09-02  7:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01  8:16 [PATCH] ci: fix missing Ruby dependency in "documentation" job Patrick Steinhardt
2026-09-01  8:24 ` Toon Claes
2026-09-01  8:36   ` Patrick Steinhardt
2026-09-01  8:47 ` Jeff King
2026-09-01  8:51   ` Jeff King
2026-09-01 10:41   ` Patrick Steinhardt
2026-09-02  7:11     ` [PATCH 0/2] bump ci asciidoctor version Jeff King
2026-09-02  7:14       ` Jeff King [this message]
2026-09-02  7:16       ` [PATCH 2/2] ci: use system asciidoctor Jeff King
2026-09-02  7:55         ` Patrick Steinhardt
2026-09-02  9:01           ` Jeff King
2026-09-02  9:59             ` Patrick Steinhardt
2026-09-05 14:02               ` Jeff King
2026-09-05 15:23                 ` Todd Zullinger
2026-09-11 20:42                   ` Jeff King
2026-09-11 19:52       ` [PATCH (RESEND)] " Tuomas Ahola
2026-09-11 20:38         ` Jeff King
2026-09-11 20:58         ` Junio C Hamano
2026-09-11 21:33           ` Tuomas Ahola
2026-09-11 21:50             ` Junio C Hamano
2026-09-01 17:58   ` [PATCH] ci: fix missing Ruby dependency in "documentation" job Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260902071409.GA641414@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jn.avila@free.fr \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox