Git development
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Cc: Brigham Campbell <me@brighamcampbell.com>,
	git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Patrick Steinhardt <ps@pks.im>, Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH] doc: Make asciidoc bullet items separate
Date: Thu, 10 Sep 2026 12:38:20 -0400	[thread overview]
Message-ID: <20260910163820.GE251185@coredump.intra.peff.net> (raw)
In-Reply-To: <9f455224-f156-493f-a21c-27a8922f3360@app.fastmail.com>

On Mon, Sep 07, 2026 at 12:18:48PM +0200, Kristoffer Haugsbakk wrote:

> I wonder if this gives different results for asciidoc and asciidoctor.
> 
> • asciidoctor: seems that the bullet list is correct with or without
>   this change (no change)
> • asciidoc: needs this change

Yeah, I think we've run into this sort of parsing subtlety between the
two before.

I imagine this is how you did it, but for the original author and
anybody else working on documentation, it is often useful to do:

  cd Documentation
  ./doc-diff HEAD^ HEAD
  ./doc-diff --asciidoctor HEAD^ HEAD

to see how your changes work in both systems. You can also do:

  ./doc-diff --from-asciidoctor --to-asciidoc HEAD HEAD

to see how the two renderers differ currently, but there's quite a lot
of noise (differing wrapping, indentation, use of quotes, etc). All of
those may be candidates for examination and fixing, but it is a lot of
noise if you are looking at your one area. ;)

> I also idly wonder why git-scm renders this bullet list as it ought
> to. This hunk has not been modified for a while. The second paragraph
> which ostensibly made it conjoined was d9bccf2e (builtin/maintenance:
> introduce "geometric" strategy, 2025-10-24).

It uses asciidoctor. :)

-Peff

  reply	other threads:[~2026-09-10 16:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-07  7:15 [PATCH] doc: Make asciidoc bullet items separate Brigham Campbell
2026-09-07  8:46 ` Patrick Steinhardt
2026-09-07 17:10   ` Brigham Campbell
2026-09-07 10:18 ` Kristoffer Haugsbakk
2026-09-10 16:38   ` Jeff King [this message]
2026-09-10  6:52 ` [PATCH v2] doc: fix conjoined maintenance strategies in git-config(1) Brigham Campbell
2026-09-10  8:17   ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260910163820.GE251185@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=me@brighamcampbell.com \
    --cc=me@ttaylorr.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox