From: "Brigham Campbell" <me@brighamcampbell.com>
To: "Patrick Steinhardt" <ps@pks.im>,
"Brigham Campbell" <me@brighamcampbell.com>
Cc: <git@vger.kernel.org>, "Junio C Hamano" <gitster@pobox.com>,
"Taylor Blau" <me@ttaylorr.com>
Subject: Re: [PATCH] doc: Make asciidoc bullet items separate
Date: Mon, 07 Sep 2026 11:10:15 -0600 [thread overview]
Message-ID: <DL991DWRB590.NECVWISEVRKG@brighamcampbell.com> (raw)
In-Reply-To: <ap55z8P8i2hqddAL@pks.im>
On Mon Sep 7, 2026 at 2:46 AM MDT, Patrick Steinhardt wrote:
> Not, probably not worth a reroll: it would have been nice to point out
> that this is in git-config(1). E.g. something like this:
>
> doc: fix conjoined maintenance strategies in git-config(1)
>
> Fix conjoined bullet items for the maintennace
maintennace -> maintenance
> strategies in
> git-config(1).
I'll mention git-config(1) in v2 if maintainers request a new revision
(though I agree that a patch this simple probably doesn't need a
reroll). Otherwise, I invite the committer to make editorial changes to
the commit message as they see fit.
>> diff --git a/Documentation/config/maintenance.adoc b/Documentation/config/maintenance.adoc
>> index da8be9f812..c778ab09ac 100644
>> --- a/Documentation/config/maintenance.adoc
>> +++ b/Documentation/config/maintenance.adoc
>> @@ -41,6 +41,7 @@ The possible strategies are:
>> This repacking strategy is a full replacement for the `gc` strategy and is
>> recommended for large repositories. This is the default strategy for manual
>> maintenance.
>> ++
>> * `incremental`: This setting optimizes for performing small maintenance
>> activities that do not delete any data. This does not schedule the `gc`
>> task, but runs the `prefetch` and `commit-graph` tasks hourly, the
>
> Ah, indeed. I can confirm that this is misrendered when looking at
> git-config(1), and with your patch it indeed renders correctly. Thanks
> for this simple and obvious fix!
Thanks for the review! It's a minor change, but this is my first patch
to the git project, so I appreciate your time and expertise.
Cheers!
--
Brigham Campbell
https://brighamcampbell.com
next prev parent reply other threads:[~2026-09-07 17:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 7:15 [PATCH] doc: Make asciidoc bullet items separate Brigham Campbell
2026-09-07 8:46 ` Patrick Steinhardt
2026-09-07 17:10 ` Brigham Campbell [this message]
2026-09-07 10:18 ` Kristoffer Haugsbakk
2026-09-10 16:38 ` Jeff King
2026-09-10 6:52 ` [PATCH v2] doc: fix conjoined maintenance strategies in git-config(1) Brigham Campbell
2026-09-10 8:17 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DL991DWRB590.NECVWISEVRKG@brighamcampbell.com \
--to=me@brighamcampbell.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox