* [PATCH v6 1/3] t4001: modernize
2026-09-22 20:21 [PATCH v6 0/3] t40*: modernize Mark C. Chu-Carroll
@ 2026-09-22 20:21 ` Mark C. Chu-Carroll
2026-09-22 20:21 ` [PATCH v6 2/3] t4009: modernize Mark C. Chu-Carroll
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Mark C. Chu-Carroll @ 2026-09-22 20:21 UTC (permalink / raw)
To: git; +Cc: Mark C. Chu-Carroll
Old tests were written in a different style than modern
ones; for better readability and test error messages,
update t4001 to the modern style.
* run everything inside of a test_expect_success block.
* write title line on the same line as test_expect_success,
end that line with a single quote that opens the body of the test,
and end the test with a single quote that closes the body.
* write expected output of a test to a file named "expect",
and actual output to a file named "actual".
* write here-docs using "<<-" syntax, so that they're indented
uniformly with the rest of the test.
* make test names more clearly reflect the functionality that
they test.
Signed-off-by: Mark C. Chu-Carroll <markchucarroll@fastmail.com>
---
t/t4001-diff-rename.sh | 89 ++++++++++++++++++------------------------
1 file changed, 38 insertions(+), 51 deletions(-)
diff --git a/t/t4001-diff-rename.sh b/t/t4001-diff-rename.sh
index ad474100af..1a2474af10 100755
--- a/t/t4001-diff-rename.sh
+++ b/t/t4001-diff-rename.sh
@@ -26,7 +26,7 @@ test_expect_success 'setup' '
Line 14
Line 15
EOF
- cat >expected <<-\EOF &&
+ cat >expect <<-\EOF &&
diff --git a/path0 b/path1
rename from path0
rename to path1
@@ -42,7 +42,7 @@ test_expect_success 'setup' '
Line 13
Line 14
EOF
- cat >no-rename <<-\EOF
+ cat >expect-no-rename <<-\EOF &&
diff --git a/path0 b/path0
deleted file mode 100644
index fdbec44..0000000
@@ -86,47 +86,34 @@ test_expect_success 'setup' '
+Line 14
+Line 15
EOF
+ git update-index --add path0
'
-test_expect_success \
- 'update-index --add a file.' \
- 'git update-index --add path0'
-
-test_expect_success \
- 'write that tree.' \
- 'tree=$(git write-tree) && echo $tree'
-
-sed -e 's/line/Line/' <path0 >path1
-rm -f path0
-test_expect_success \
- 'renamed and edited the file.' \
- 'git update-index --add --remove path0 path1'
-
-test_expect_success \
- 'git diff-index -p -M after rename and editing.' \
- 'git diff-index -p -M $tree >current'
-
-
-test_expect_success \
- 'validate the output.' \
- 'compare_diff_patch current expected'
+test_expect_success 'diff shows path0 renamed to path1 with edit' '
+ tree=$(git write-tree) &&
+ sed -e "s/line/Line/" <path0 >path1 &&
+ rm -f path0 &&
+ git update-index --add --remove path0 path1 &&
+ git diff-index -p -M $tree >actual &&
+ compare_diff_patch actual expect
+'
-test_expect_success 'test diff.renames=true' '
- git -c diff.renames=true diff --cached $tree >current &&
- compare_diff_patch current expected
+test_expect_success 'with diff.renames=true, patch includes rename of path0 to path1' '
+ git -c diff.renames=true diff --cached $tree >actual &&
+ compare_diff_patch actual expect
'
-test_expect_success 'test diff.renames=false' '
- git -c diff.renames=false diff --cached $tree >current &&
- compare_diff_patch current no-rename
+test_expect_success 'with diff.renames=false, patch does not include rename' '
+ git -c diff.renames=false diff --cached $tree >actual &&
+ compare_diff_patch actual expect-no-rename
'
-test_expect_success 'test diff.renames unset' '
- git diff --cached $tree >current &&
- compare_diff_patch current expected
+test_expect_success 'with no setting for diff.renames, patch includes rename' '
+ git diff --cached $tree >actual &&
+ compare_diff_patch actual expect
'
-test_expect_success 'favour same basenames over different ones' '
+test_expect_success 'diff rename favours same basenames over different ones' '
cp path1 another-path &&
git add another-path &&
git commit -m 1 &&
@@ -137,25 +124,25 @@ test_expect_success 'favour same basenames over different ones' '
test_grep "renamed: .*path1 -> subdir/path1" out
'
-test_expect_success 'test diff.renames=true for git status' '
+test_expect_success 'with diff.renames=true, git status includes rename' '
git -c diff.renames=true status >out &&
test_grep "renamed: .*path1 -> subdir/path1" out
'
-test_expect_success 'test diff.renames=false for git status' '
+test_expect_success 'with diff.renames=false, git status shows delete/add' '
git -c diff.renames=false status >out &&
test_grep ! "renamed: .*path1 -> subdir/path1" out &&
test_grep "new file: .*subdir/path1" out &&
test_grep "deleted: .*[^/]path1" out
'
-test_expect_success 'favour same basenames even with minor differences' '
+test_expect_success 'rename logic favours same basenames even with minor differences' '
git show HEAD:path1 | sed "s/15/16/" > subdir/path1 &&
git status >out &&
test_grep "renamed: .*path1 -> subdir/path1" out
'
-test_expect_success 'two files with same basename and same content' '
+test_expect_success 'rename logic favors common path segments for files with the same basename and content' '
git reset --hard &&
mkdir -p dir/A dir/B &&
cp path1 dir/A/file &&
@@ -167,7 +154,7 @@ test_expect_success 'two files with same basename and same content' '
test_grep "renamed: .*dir/A/file -> other-dir/A/file" out
'
-test_expect_success 'setup for many rename source candidates' '
+test_expect_success 'rename with many candidates' '
git reset --hard &&
for i in 0 1 2 3 4 5 6 7 8 9;
do
@@ -184,7 +171,7 @@ test_expect_success 'setup for many rename source candidates' '
git add new-path path1 &&
git diff -l 4 -C -C --cached --name-status >actual 2>actual.err &&
sed -e "s/^\([CM]\)[0-9]* /\1 /" actual >actual.munged &&
- cat >expect <<-EOF &&
+ cat >expect <<-\EOF &&
C path1 new-path
M path1
EOF
@@ -192,7 +179,7 @@ test_expect_success 'setup for many rename source candidates' '
test_grep warning actual.err
'
-test_expect_success 'rename pretty print with nothing in common' '
+test_expect_success 'pretty-print paths with nothing in common after rename' '
mkdir -p a/b/ &&
: >a/b/c &&
git add a/b/c &&
@@ -206,7 +193,7 @@ test_expect_success 'rename pretty print with nothing in common' '
test_grep " a/b/c => c/b/a " output
'
-test_expect_success 'rename pretty print with common prefix' '
+test_expect_success 'pretty print paths with common prefix after rename' '
mkdir -p c/d &&
git mv c/b/a c/d/e &&
git commit -m "c/b/a -> c/d/e" &&
@@ -216,7 +203,7 @@ test_expect_success 'rename pretty print with common prefix' '
test_grep " c/{b/a => d/e} " output
'
-test_expect_success 'rename pretty print with common suffix' '
+test_expect_success 'pretty prints paths with common suffix after rename' '
mkdir d &&
git mv c/d/e d/e &&
git commit -m "c/d/e -> d/e" &&
@@ -226,7 +213,7 @@ test_expect_success 'rename pretty print with common suffix' '
test_grep " {c/d => d}/e " output
'
-test_expect_success 'rename pretty print with common prefix and suffix' '
+test_expect_success 'pretty prints paths with common prefix and suffix after rename' '
mkdir d/f &&
git mv d/e d/f/e &&
git commit -m "d/e -> d/f/e" &&
@@ -236,7 +223,7 @@ test_expect_success 'rename pretty print with common prefix and suffix' '
test_grep " d/{ => f}/e " output
'
-test_expect_success 'rename pretty print common prefix and suffix overlap' '
+test_expect_success 'pretty prints paths with common prefix and suffix overlap after rename' '
mkdir d/f/f &&
git mv d/f/e d/f/f/e &&
git commit -m "d/f/e d/f/f/e" &&
@@ -261,7 +248,7 @@ test_expect_success 'diff-tree -l0 defaults to a big rename limit, not zero' '
test_grep "myotherfile.*myfile" actual
'
-test_expect_success 'basename similarity vs best similarity' '
+test_expect_success 'rename prefers basename similarity over best similarity' '
mkdir subdir &&
test_write_lines line1 line2 line3 line4 line5 \
line6 line7 line8 line9 line10 >subdir/file.txt &&
@@ -278,14 +265,14 @@ test_expect_success 'basename similarity vs best similarity' '
git diff-tree -r -M --name-status HEAD^ HEAD >actual &&
# subdir/file.txt is 88% similar to file.md, 78% similar to file.txt,
# but since same basenames are checked first...
- cat >expected <<-\EOF &&
+ cat >expect <<-\EOF &&
A file.md
R078 subdir/file.txt file.txt
EOF
- test_cmp expected actual
+ test_cmp expect actual
'
-test_expect_success 'last line matters too' '
+test_expect_success 'file similarity handles missing trailing newline.' '
{
test_write_lines a 0 1 2 3 4 5 6 7 8 9 &&
printf "git ignores final up to 63 characters if not newline terminated"
@@ -303,10 +290,10 @@ test_expect_success 'last line matters too' '
git commit -a -m "rename no-final-lf -> still-absent-final-lf" &&
git diff-tree -r -M --name-status HEAD^ HEAD >actual &&
sed -e "s/^R[0-9]* /R /" actual >actual.munged &&
- cat >expected <<-\EOF &&
+ cat >expect <<-\EOF &&
R no-final-lf still-absent-final-lf
EOF
- test_cmp expected actual.munged
+ test_cmp expect actual.munged
'
test_done
--
2.53.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v6 2/3] t4009: modernize
2026-09-22 20:21 [PATCH v6 0/3] t40*: modernize Mark C. Chu-Carroll
2026-09-22 20:21 ` [PATCH v6 1/3] t4001: modernize Mark C. Chu-Carroll
@ 2026-09-22 20:21 ` Mark C. Chu-Carroll
2026-09-22 20:21 ` [PATCH v6 3/3] t4010: modernize Mark C. Chu-Carroll
2026-09-24 14:58 ` [PATCH v6 0/3] t40*: modernize Kaartic Sivaraam
3 siblings, 0 replies; 8+ messages in thread
From: Mark C. Chu-Carroll @ 2026-09-22 20:21 UTC (permalink / raw)
To: git; +Cc: Mark C. Chu-Carroll
Old tests were written in a different style than modern
ones; for better readability and test error messages,
update t4009 to the modern style.
* run everything inside of a test_expect_success block.
* write title line on the same line as test_expect_success,
end that line with a single quote that opens the body of the test,
and end the test with a single quote that closes the body.
* write expected output of a test to a file named "expect",
and actual output to a file named "actual".
* write here-docs using "<<-" syntax, so that they're indented
uniformly with the rest of the test.
* make test names more clearly reflect the functionality that
they test.
Signed-off-by: Mark C. Chu-Carroll <markchucarroll@fastmail.com>
---
t/t4009-diff-rename-4.sh | 142 +++++++++++++++++++--------------------
1 file changed, 68 insertions(+), 74 deletions(-)
diff --git a/t/t4009-diff-rename-4.sh b/t/t4009-diff-rename-4.sh
index 59e71e3acd..e42891ee5a 100755
--- a/t/t4009-diff-rename-4.sh
+++ b/t/t4009-diff-rename-4.sh
@@ -10,68 +10,64 @@ test_description='Same rename detection as t4003 but testing diff-raw -z.
. ./test-lib.sh
. "$TEST_DIRECTORY"/lib-diff.sh ;# test-lib chdir's into trash
-test_expect_success \
- 'prepare reference tree' \
- 'COPYING_test_data >COPYING &&
- echo frotz >rezrov &&
- git update-index --add COPYING rezrov &&
- orig=$(git hash-object COPYING) &&
- tree=$(git write-tree) &&
- echo $tree'
-
-test_expect_success \
- 'prepare work tree' \
- 'sed -e 's/HOWEVER/However/' <COPYING >COPYING.1 &&
- sed -e 's/GPL/G.P.L/g' <COPYING >COPYING.2 &&
- rm -f COPYING &&
- c1=$(git hash-object COPYING.1) &&
- c2=$(git hash-object COPYING.2) &&
- git update-index --add --remove COPYING COPYING.?'
-
-# tree has COPYING and rezrov. work tree has COPYING.1 and COPYING.2,
-# both are slightly edited, and unchanged rezrov. We say COPYING.1
-# and COPYING.2 are based on COPYING, and do not say anything about
-# rezrov.
-
-git diff-index -z -C $tree >current
-
-cat >expected <<EOF
-:100644 100644 $orig $c1 C1234
-COPYING
-COPYING.1
-:100644 100644 $orig $c2 R1234
-COPYING
-COPYING.2
-EOF
-
-test_expect_success \
- 'validate output from rename/copy detection (#1)' \
- 'compare_diff_raw_z current expected'
+test_expect_success 'setup' '
+ # prepare reference tree
+ COPYING_test_data >COPYING &&
+ echo frotz >rezrov &&
+ git update-index --add COPYING rezrov &&
+ orig=$(git hash-object COPYING) &&
+ tree=$(git write-tree) &&
+ echo $tree &&
+ # prepare work tree
+ sed -e "s/HOWEVER/However/" <COPYING >COPYING.1 &&
+ sed -e "s/GPL/G.P.L/g" <COPYING >COPYING.2 &&
+ rm -f COPYING &&
+ c1=$(git hash-object COPYING.1) &&
+ c2=$(git hash-object COPYING.2) &&
+ git update-index --add --remove COPYING COPYING.?
+'
+
+test_expect_success 'validate output from rename/copy detection (#1)' '
+ # tree has COPYING and rezrov. work tree has COPYING.1 and COPYING.2,
+ # both are slightly edited, and unchanged rezrov. We say COPYING.1
+ # and COPYING.2 are based on COPYING, and do not say anything about
+ # rezrov.
+ cat >expect <<-EOF &&
+ :100644 100644 $orig $c1 C1234
+ COPYING
+ COPYING.1
+ :100644 100644 $orig $c2 R1234
+ COPYING
+ COPYING.2
+ EOF
+
+ git diff-index -z -C $tree >actual &&
+ compare_diff_raw_z actual expect
+'
################################################################
-test_expect_success \
- 'prepare work tree again' \
- 'mv COPYING.2 COPYING &&
- git update-index --add --remove COPYING COPYING.1 COPYING.2'
-
-# tree has COPYING and rezrov. work tree has COPYING and COPYING.1,
-# both are slightly edited, and unchanged rezrov. We say COPYING.1
-# is based on COPYING and COPYING is still there, and do not say anything
-# about rezrov.
-
-git diff-index -z -C $tree >current
-cat >expected <<EOF
-:100644 100644 $orig $c2 M
-COPYING
-:100644 100644 $orig $c1 C1234
-COPYING
-COPYING.1
-EOF
-
-test_expect_success \
- 'validate output from rename/copy detection (#2)' \
- 'compare_diff_raw_z current expected'
+test_expect_success 'validate output from rename/copy detection (#2)' '
+ # prepare work tree again
+ mv COPYING.2 COPYING &&
+ git update-index --add --remove COPYING COPYING.1 COPYING.2 &&
+
+ # tree has COPYING and rezrov. work tree has COPYING and COPYING.1,
+ # both are slightly edited, and unchanged rezrov. We say COPYING.1
+ # is based on COPYING and COPYING is still there, and do not say anything
+ # about rezrov.
+
+ git diff-index -z -C $tree >actual &&
+ cat >expect <<-EOF &&
+ :100644 100644 $orig $c2 M
+ COPYING
+ :100644 100644 $orig $c1 C1234
+ COPYING
+ COPYING.1
+ EOF
+
+ compare_diff_raw_z actual expect
+'
################################################################
@@ -80,20 +76,18 @@ test_expect_success \
# anything about rezrov or COPYING, since the revised again diff-raw
# nows how to say Copy.
-test_expect_success \
- 'prepare work tree once again' \
- 'COPYING_test_data >COPYING &&
- git update-index --add --remove COPYING COPYING.1'
-
-git diff-index -z -C --find-copies-harder $tree >current
-cat >expected <<EOF
-:100644 100644 $orig $c1 C1234
-COPYING
-COPYING.1
-EOF
-
-test_expect_success \
- 'validate output from rename/copy detection (#3)' \
- 'compare_diff_raw_z current expected'
+test_expect_success 'validate output from rename/copy detection (#3)' '
+ # prepare work tree once again
+ COPYING_test_data >COPYING &&
+ git update-index --add --remove COPYING COPYING.1 &&
+ git diff-index -z -C --find-copies-harder $tree >actual &&
+ cat >expect <<-EOF &&
+ :100644 100644 $orig $c1 C1234
+ COPYING
+ COPYING.1
+ EOF
+
+ compare_diff_raw_z actual expect
+'
test_done
--
2.53.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v6 3/3] t4010: modernize
2026-09-22 20:21 [PATCH v6 0/3] t40*: modernize Mark C. Chu-Carroll
2026-09-22 20:21 ` [PATCH v6 1/3] t4001: modernize Mark C. Chu-Carroll
2026-09-22 20:21 ` [PATCH v6 2/3] t4009: modernize Mark C. Chu-Carroll
@ 2026-09-22 20:21 ` Mark C. Chu-Carroll
2026-09-24 14:58 ` [PATCH v6 0/3] t40*: modernize Kaartic Sivaraam
3 siblings, 0 replies; 8+ messages in thread
From: Mark C. Chu-Carroll @ 2026-09-22 20:21 UTC (permalink / raw)
To: git; +Cc: Mark C. Chu-Carroll
Old tests were written in a different style than modern
ones; for better readability and test error messages,
update t4010 to the modern style.
* run everything inside of a test_expect_success block.
* write title line on the same line as test_expect_success,
end that line with a single quote that opens the body of the test,
and end the test with a single quote that closes the body.
* write expected output of a test to a file named "expect",
and actual output to a file named "actual".
* write here-docs using "<<-" syntax, so that they're indented
uniformly with the rest of the test.
* make test names more clearly reflect the functionality that
they test.
Signed-off-by: Mark C. Chu-Carroll <markchucarroll@fastmail.com>
---
t/t4010-diff-pathspec.sh | 122 +++++++++++++++++++--------------------
1 file changed, 61 insertions(+), 61 deletions(-)
diff --git a/t/t4010-diff-pathspec.sh b/t/t4010-diff-pathspec.sh
index c84c3fa05b..03b3023bee 100755
--- a/t/t4010-diff-pathspec.sh
+++ b/t/t4010-diff-pathspec.sh
@@ -13,67 +13,67 @@ Prepare:
. ./test-lib.sh
. "$TEST_DIRECTORY"/lib-diff.sh ;# test-lib chdir's into trash
-test_expect_success \
- setup \
- 'echo frotz >file0 &&
- mkdir path1 &&
- echo rezrov >path1/file1 &&
- before0=$(git hash-object file0) &&
- before1=$(git hash-object path1/file1) &&
- git update-index --add file0 path1/file1 &&
- tree=$(git write-tree) &&
- echo "$tree" &&
- echo nitfol >file0 &&
- echo yomin >path1/file1 &&
- after0=$(git hash-object file0) &&
- after1=$(git hash-object path1/file1) &&
- git update-index file0 path1/file1'
-
-cat >expected <<\EOF
-EOF
-test_expect_success \
- 'limit to path should show nothing' \
- 'git diff-index --cached $tree -- path >current &&
- compare_diff_raw current expected'
-
-cat >expected <<EOF
-:100644 100644 $before1 $after1 M path1/file1
-EOF
-test_expect_success \
- 'limit to path1 should show path1/file1' \
- 'git diff-index --cached $tree -- path1 >current &&
- compare_diff_raw current expected'
-
-cat >expected <<EOF
-:100644 100644 $before1 $after1 M path1/file1
-EOF
-test_expect_success \
- 'limit to path1/ should show path1/file1' \
- 'git diff-index --cached $tree -- path1/ >current &&
- compare_diff_raw current expected'
-
-cat >expected <<EOF
-:100644 100644 $before1 $after1 M path1/file1
-EOF
-test_expect_success \
- '"*file1" should show path1/file1' \
- 'git diff-index --cached $tree -- "*file1" >current &&
- compare_diff_raw current expected'
-
-cat >expected <<EOF
-:100644 100644 $before0 $after0 M file0
-EOF
-test_expect_success \
- 'limit to file0 should show file0' \
- 'git diff-index --cached $tree -- file0 >current &&
- compare_diff_raw current expected'
-
-cat >expected <<\EOF
-EOF
-test_expect_success \
- 'limit to file0/ should emit nothing.' \
- 'git diff-index --cached $tree -- file0/ >current &&
- compare_diff_raw current expected'
+test_expect_success 'setup' '
+ echo frotz >file0 &&
+ mkdir path1 &&
+ echo rezrov >path1/file1 &&
+ before0=$(git hash-object file0) &&
+ before1=$(git hash-object path1/file1) &&
+ git update-index --add file0 path1/file1 &&
+ tree=$(git write-tree) &&
+ echo nitfol >file0 &&
+ echo yomin >path1/file1 &&
+ after0=$(git hash-object file0) &&
+ after1=$(git hash-object path1/file1) &&
+ git update-index file0 path1/file1 &&
+ : >expected
+'
+
+test_expect_success 'limit to path should show nothing' '
+ git diff-index --cached $tree -- path >current &&
+ compare_diff_raw current expected
+'
+
+test_expect_success 'limit to path1 should show path1/file1' '
+ cat >expected <<-EOF &&
+ :100644 100644 $before1 $after1 M path1/file1
+ EOF
+
+ git diff-index --cached $tree -- path1 >current &&
+ compare_diff_raw current expected
+'
+
+test_expect_success 'limit to path1/ should show path1/file1' '
+ cat >expected <<-EOF &&
+ :100644 100644 $before1 $after1 M path1/file1
+ EOF
+
+ git diff-index --cached $tree -- path1/ >current &&
+ compare_diff_raw current expected
+'
+test_expect_success '"*file1" should show path1/file1' '
+ cat >expected <<-EOF &&
+ :100644 100644 $before1 $after1 M path1/file1
+ EOF
+
+ git diff-index --cached $tree -- "*file1" >current &&
+ compare_diff_raw current expected
+'
+
+test_expect_success 'limit to file0 should show file0' '
+ cat >expected <<-EOF &&
+ :100644 100644 $before0 $after0 M file0
+ EOF
+
+ git diff-index --cached $tree -- file0 >current &&
+ compare_diff_raw current expected
+'
+
+test_expect_success 'limit to file0/ should emit nothing.' '
+ : >expected &&
+ git diff-index --cached $tree -- file0/ >current &&
+ compare_diff_raw current expected
+'
test_expect_success 'diff-tree pathspec' '
tree2=$(git write-tree) &&
--
2.53.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v6 0/3] t40*: modernize
2026-09-22 20:21 [PATCH v6 0/3] t40*: modernize Mark C. Chu-Carroll
` (2 preceding siblings ...)
2026-09-22 20:21 ` [PATCH v6 3/3] t4010: modernize Mark C. Chu-Carroll
@ 2026-09-24 14:58 ` Kaartic Sivaraam
2026-09-24 16:13 ` Junio C Hamano
2026-09-24 17:20 ` Mark C. Chu-Carroll
3 siblings, 2 replies; 8+ messages in thread
From: Kaartic Sivaraam @ 2026-09-24 14:58 UTC (permalink / raw)
To: Mark C. Chu-Carroll; +Cc: git
On 9/23/26 01:51, Mark C. Chu-Carroll wrote:
> Changes in v6:
> - Fix rebase error to separate commits correctly.
>
> - Link to v5: https://lore.kernel.org/git/20260922143119.3313620-1-markchucarroll@fastmail.com/T/#t
>
Just a tip, you might want to use the --in-reply-to to mention the
message ID of your previous iteration's cover letter. This ensures your
iterations end up in the same thread. With this, you do not need to
manually include links to the previous iteration.
Example of such a thread:
https://lore.kernel.org/git/xmqqecfez7ie.fsf@gitster.g/T/#t
See also, "Sending v2" section of MyFirstContribution
https://git-scm.com/docs/MyFirstContribution#v2-git-send-email
--
Sivaraam
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v6 0/3] t40*: modernize
2026-09-24 14:58 ` [PATCH v6 0/3] t40*: modernize Kaartic Sivaraam
@ 2026-09-24 16:13 ` Junio C Hamano
2026-09-24 17:20 ` Mark C. Chu-Carroll
1 sibling, 0 replies; 8+ messages in thread
From: Junio C Hamano @ 2026-09-24 16:13 UTC (permalink / raw)
To: Kaartic Sivaraam; +Cc: Mark C. Chu-Carroll, git
Kaartic Sivaraam <kaartic.sivaraam@gmail.com> writes:
> See also, "Sending v2" section of MyFirstContribution
>
> https://git-scm.com/docs/MyFirstContribution#v2-git-send-email
Thanks. It also worth noting that the section referred to from the
beginning of "Sending v2" section is also valuable.
https://git-scm.com/docs/MyFirstContribution#reviewing
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v6 0/3] t40*: modernize
2026-09-24 14:58 ` [PATCH v6 0/3] t40*: modernize Kaartic Sivaraam
2026-09-24 16:13 ` Junio C Hamano
@ 2026-09-24 17:20 ` Mark C. Chu-Carroll
2026-09-25 13:40 ` Kaartic Sivaraam
1 sibling, 1 reply; 8+ messages in thread
From: Mark C. Chu-Carroll @ 2026-09-24 17:20 UTC (permalink / raw)
To: Kaartic Sivaraam, Mark C. Chu-Carroll; +Cc: git
On Thu Sep 24, 2026 at 10:58 AM EDT, Kaartic Sivaraam wrote:
> On 9/23/26 01:51, Mark C. Chu-Carroll wrote:
>> Changes in v6:
>> - Fix rebase error to separate commits correctly.
>>
>> - Link to v5: https://lore.kernel.org/git/20260922143119.3313620-1-markchucarroll@fastmail.com/T/#t
>>
>
> Just a tip, you might want to use the --in-reply-to to mention the
> message ID of your previous iteration's cover letter. This ensures your
> iterations end up in the same thread. With this, you do not need to
> manually include links to the previous iteration.
Should I resend this with the in-reply-to to attach it to the thread, or
just leave it this time?
-Mark
--
Mark Craig Chu-Carroll (@MarkChuCarroll at gitlab)
*** Software Tools/Math Geek - Software Engineer at Gitlab
*** Work Email: mcarroll@gitlab.com / markchucarroll@fastmail.com
*** Personal Blog: http://goodmath.org/blog / Personal email: markcc@gmail.com
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v6 0/3] t40*: modernize
2026-09-24 17:20 ` Mark C. Chu-Carroll
@ 2026-09-25 13:40 ` Kaartic Sivaraam
0 siblings, 0 replies; 8+ messages in thread
From: Kaartic Sivaraam @ 2026-09-25 13:40 UTC (permalink / raw)
To: Mark C. Chu-Carroll; +Cc: git
On 9/24/26 22:50, Mark C. Chu-Carroll wrote:
> On Thu Sep 24, 2026 at 10:58 AM EDT, Kaartic Sivaraam wrote:
>>
>> Just a tip, you might want to use the --in-reply-to to mention the
>> message ID of your previous iteration's cover letter. This ensures your
>> iterations end up in the same thread. With this, you do not need to
>> manually include links to the previous iteration.
>
> Should I resend this with the in-reply-to to attach it to the thread, or
> just leave it this time?
>
I may not be the best to comment. Yet, I believe it should be fine to
start doing that from the next version.
--
Sivaraam
^ permalink raw reply [flat|nested] 8+ messages in thread