From: Jeff King <peff@peff.net>
To: Patrick Steinhardt <ps@pks.im>
Cc: Junio C Hamano <gitster@pobox.com>,
Pushkar Singh <pushkarkumarsingh1970@gmail.com>,
git@vger.kernel.org, r.norouzi@proton.me
Subject: Re: [PATCH v2] reflog: fix default expiry periods
Date: Thu, 24 Sep 2026 11:46:59 -0400 [thread overview]
Message-ID: <20260924154659.GA736248@coredump.intra.peff.net> (raw)
In-Reply-To: <arUvtE67n5_MFM4C@pks.im>
On Thu, Sep 24, 2026 at 04:12:04PM +0200, Patrick Steinhardt wrote:
> > > #define REFLOG_EXPIRE_OPTIONS_INIT(now) { \
> > > - .default_expire_total = now - 30 * 24 * 3600, \
> > > - .default_expire_unreachable = now - 90 * 24 * 3600, \
> > > + .default_expire_total = now - 90 * 24 * 3600, \
> > > + .default_expire_unreachable = now - 30 * 24 * 3600, \
> > > }
> >
> > and the fix is very straight-forward.
>
> Is this something that we want to fast-track for Git 2.56?
The breakage was in v2.50.0, so it is not a new regression. OTOH it
seems quite obvious and low-risk. I'd be OK either way.
-Peff
next prev parent reply other threads:[~2026-09-24 15:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 18:32 reflog expire: default expiry times swapped since 2.50 r.norouzi
2026-09-22 16:54 ` [PATCH] reflog: fix default expiry periods Pushkar Singh
2026-09-22 17:27 ` Junio C Hamano
2026-09-22 18:02 ` Jeff King
2026-09-23 12:21 ` Patrick Steinhardt
2026-09-23 10:21 ` [PATCH v2] " Pushkar Singh
2026-09-23 19:26 ` Junio C Hamano
2026-09-24 14:12 ` Patrick Steinhardt
2026-09-24 15:46 ` Jeff King [this message]
2026-09-24 17:45 ` Junio C Hamano
2026-09-24 18:43 ` Jeff King
2026-09-28 6:53 ` Patrick Steinhardt
2026-09-24 17:43 ` Junio C Hamano
2026-09-24 17:58 ` [PATCH v3] " Pushkar Singh
2026-09-24 18:26 ` Junio C Hamano
2026-09-28 7:02 ` Patrick Steinhardt
2026-09-28 14:50 ` Junio C Hamano
2026-09-29 5:45 ` Patrick Steinhardt
2026-09-29 18:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924154659.GA736248@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ps@pks.im \
--cc=pushkarkumarsingh1970@gmail.com \
--cc=r.norouzi@proton.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox