From: Jeff King <peff@peff.net>
To: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Cc: git@vger.kernel.org
Subject: [PATCH 0/2] some parse_revision_opt() bugfixes
Date: Fri, 25 Sep 2026 16:33:59 -0400 [thread overview]
Message-ID: <20260925203359.GA1506705@coredump.intra.peff.net> (raw)
In-Reply-To: <20260925082636.GA1493716@coredump.intra.peff.net>
On Fri, Sep 25, 2026 at 04:26:36AM -0400, Jeff King wrote:
> > I have bisected this to cd439487 (revision: manage memory ownership of
> > argv in setup_revisions(), 2025-09-19).
>
> Yep, definitely my fault. I don't have time to do a full write-up now,
> but the most direct solution is:
> [...]
> But I think instead doing this:
I ended up reversing my decision there, for reasons that are explained
in the second commit. But the good news is that doing so also revealed a
related bug that predates even cd439487.
So here are the fixes. I apologize in advance for the length of the
second commit message. At least I feel good about my decision to go to
bed before writing it. ;)
[1/2]: revision: avoid reporting known options as unknown on error
[2/2]: revision: handle argv movement in parse_revision_opt()
revision.c | 7 +++++--
t/t4201-shortlog.sh | 11 +++++++++++
2 files changed, 16 insertions(+), 2 deletions(-)
-Peff
next prev parent reply other threads:[~2026-09-25 20:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 0:28 [BUG] revision: premature free-and-null causes “unknown option `(null)`” Kristoffer Haugsbakk
2026-09-25 8:26 ` Jeff King
2026-09-25 20:33 ` Jeff King [this message]
2026-09-25 20:35 ` [PATCH 1/2] revision: avoid reporting known options as unknown on error Jeff King
2026-09-25 20:39 ` [PATCH 2/2] revision: handle argv movement in parse_revision_opt() Jeff King
2026-09-26 9:00 ` Kristoffer Haugsbakk
2026-09-28 3:25 ` Jeff King
2026-09-29 7:43 ` Kristoffer Haugsbakk
2026-09-25 22:23 ` [PATCH 0/2] some parse_revision_opt() bugfixes Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925203359.GA1506705@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=kristofferhaugsbakk@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox