Git development
 help / color / mirror / Atom feed
From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
To: "Jeff King" <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] revision: handle argv movement in parse_revision_opt()
Date: Tue, 29 Sep 2026 09:43:15 +0200	[thread overview]
Message-ID: <7ffbbf0b-4954-4ee8-863c-4ca89ae662c6@app.fastmail.com> (raw)
In-Reply-To: <20260928032553.GA493672@coredump.intra.peff.net>

 On Mon, Sep 28, 2026, at 05:25, Jeff King wrote:
> On Sat, Sep 26, 2026 at 11:00:05AM +0200, Kristoffer Haugsbakk wrote:
>> I ought to send in a `.mailmap` change with my canonical email address.
>
> We don't mailmap trailers, though. [...]

Yes, that’s the reason. There’s no dynamic remapping after the fact. But
with a mailmap entry you can ask git-check-mailmap(1) if you have the
correct entry while writing or normalizing the commit.

I had use for that once when I was collecting `Reported-by`. One report
was from three years prior. But in the meantime, this person had changed
their address. But they had recorded it in the `.mailmap`.

But for such a normalization to be workable at all I would have to try
to add something like `--evaluate-all-cmds` to git-interpret-
trailers(1). Because `trailer.<key-alias>.cmd` will not evaluate trailer
values if it is just reading in a file without any `--trailer` options
(as well).

***

Which is an itch that no one else has to care about.

  reply	other threads:[~2026-09-29  7:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-25  0:28 [BUG] revision: premature free-and-null causes “unknown option `(null)`” Kristoffer Haugsbakk
2026-09-25  8:26 ` Jeff King
2026-09-25 20:33   ` [PATCH 0/2] some parse_revision_opt() bugfixes Jeff King
2026-09-25 20:35     ` [PATCH 1/2] revision: avoid reporting known options as unknown on error Jeff King
2026-09-25 20:39     ` [PATCH 2/2] revision: handle argv movement in parse_revision_opt() Jeff King
2026-09-26  9:00       ` Kristoffer Haugsbakk
2026-09-28  3:25         ` Jeff King
2026-09-29  7:43           ` Kristoffer Haugsbakk [this message]
2026-09-25 22:23     ` [PATCH 0/2] some parse_revision_opt() bugfixes Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ffbbf0b-4954-4ee8-863c-4ca89ae662c6@app.fastmail.com \
    --to=kristofferhaugsbakk@fastmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox