From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "D. Ben Knoble" <ben.knoble@gmail.com>,
Harald Nordgren via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Harald Nordgren <haraldnordgren@gmail.com>
Subject: Re: [PATCH] object-name: accept @{p} as short for @{push}
Date: Wed, 30 Sep 2026 18:39:06 -0400 [thread overview]
Message-ID: <20260930223906.GA763270@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqbj9e8kb3.fsf@gitster.g>
On Wed, Sep 30, 2026 at 03:07:44PM -0700, Junio C Hamano wrote:
> @{u} existed since the inception of @{upstream}, as we can see in
> https://lore.kernel.org/git/20150331173740.GE18912@peff.net/ which
> is the first iteration of the patch set that added @{push}. It is
> unclear what was said during the review of v2 [*] but in the review
> of v3 https://lore.kernel.org/git/20150521045233.GA26507@peff.net/,
> nobody questioned the asymmetry between @{upstream} having a
> short-and-sweet @{u} while @{push} lacked the corresponding @{p}.
I think you have to go back further. Another contributor proposed
@{publish} with somewhat different semantics, and I requested that it
not use @{p} to avoid confusion between the two. There was also some
discussion of @{pull} (I think as an alias to @{upstream}) at the time,
which would further increase the confusion.
See this what's cooking and the actual patch threads around that time:
https://lore.kernel.org/git/xmqqoazpt45p.fsf@gitster.dls.corp.google.com/
I don't remember what ultimately happened with the @{publish} series,
but given the time-frame and the contributor, I can make some guesses.
I don't think either of those name conflicts are under current
discussion, so I don't have any particular objection. Just noting the
history.
> * https://public-inbox.org/git/?q=gmane:268185 would have given us
> a good way to find what thread Peff was referring to in the cover
> letter of v3 iteration:
>
> https://lore.kernel.org/git/20150521044429.GA5857@peff.net/
>
> Unfortunately, we are getting 502 back X-<.
I have a local archive, but the v2 thread is not enlightening. :)
-Peff
next prev parent reply other threads:[~2026-09-30 22:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 19:39 [PATCH] object-name: accept @{p} as short for @{push} Harald Nordgren via GitGitGadget
2026-09-30 21:39 ` D. Ben Knoble
2026-09-30 22:07 ` Junio C Hamano
2026-09-30 22:39 ` Jeff King [this message]
2026-10-01 3:29 ` Junio C Hamano
2026-09-30 22:52 ` Junio C Hamano
2026-10-01 7:05 ` Harald Nordgren
2026-10-02 7:49 ` [PATCH v2] " Harald Nordgren via GitGitGadget
2026-10-02 12:08 ` Ben Knoble
2026-10-02 13:57 ` Harald Nordgren
2026-10-02 14:47 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930223906.GA763270@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=haraldnordgren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox