From: Junio C Hamano <gitster@pobox.com>
To: "Harald Nordgren via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, "D. Ben Knoble" <ben.knoble@gmail.com>,
Jeff King <peff@peff.net>,
Harald Nordgren <haraldnordgren@gmail.com>
Subject: Re: [PATCH v2] object-name: accept @{p} as short for @{push}
Date: Fri, 02 Oct 2026 07:47:22 -0700 [thread overview]
Message-ID: <xmqqse2o17np.fsf@gitster.g> (raw)
In-Reply-To: <pull.2431.v2.git.git.1790927399813.gitgitgadget@gmail.com> (Harald Nordgren via GitGitGadget's message of "Fri, 02 Oct 2026 07:49:59 +0000")
"Harald Nordgren via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Harald Nordgren <haraldnordgren@gmail.com>
>
> "git log @{p}" fails with "unknown revision", even though "@{u}"
> works for "@{upstream}".
>
> The "@{upstream}" notation came with its "@{u}" short form from the
> very beginning in 28fb84382b (Introduce <branch>@{upstream} notation,
> 2009-09-10). When "@{push}" was added in adfe5d0434 (sha1_name:
> implement @{push} shorthand, 2015-05-21), "@{p}" was held back to
> avoid confusion with a proposed "@{publish}" and talk of an "@{pull}".
> Neither of those was ever added.
>
> Add the missing "@{p}" for symmetry with "@{u}".
>
> Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com>
> ---
Very well written. Thanks. Let me mark it for 'next'.
prev parent reply other threads:[~2026-10-02 14:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 19:39 [PATCH] object-name: accept @{p} as short for @{push} Harald Nordgren via GitGitGadget
2026-09-30 21:39 ` D. Ben Knoble
2026-09-30 22:07 ` Junio C Hamano
2026-09-30 22:39 ` Jeff King
2026-10-01 3:29 ` Junio C Hamano
2026-09-30 22:52 ` Junio C Hamano
2026-10-01 7:05 ` Harald Nordgren
2026-10-02 7:49 ` [PATCH v2] " Harald Nordgren via GitGitGadget
2026-10-02 12:08 ` Ben Knoble
2026-10-02 13:57 ` Harald Nordgren
2026-10-02 14:47 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqse2o17np.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=haraldnordgren@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox