From: Jeff King <peff@peff.net>
To: Isabella Caselli <bellacaselli20@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Eric Sunshine <sunshine@sunshineco.com>,
Ignacio Encinas <ignacio@iencinas.com>
Subject: Re: [PATCH 0/3] Add hostname condition to includeIf
Date: Wed, 14 Oct 2026 06:31:18 -0400 [thread overview]
Message-ID: <20261014103118.GA1356555@coredump.intra.peff.net> (raw)
In-Reply-To: <20261012015846.2649843-1-bellacaselli20@gmail.com>
On Sun, Oct 11, 2026 at 10:58:43PM -0300, Isabella Caselli wrote:
> This series adds a "hostname:" condition to includeIf, allowing a
> configuration file to be included only on machines whose hostname
> matches a pattern. It also adds GIT_HOSTNAME to "git var", so users
> can see which hostname Git uses for matching.
>
> The series is based on Ignacio Encinas's v3 from March 2024 [1].
> Ignacio dropped the series and agreed to let me give it a try,
> so I am sending it as a new series.
> The "hostname:" patch retains his work and credits him with
> Based-on-patch-by.
>
> Changes since Ignacio's v3:
> [...]
Thanks for thoroughly collecting and including all of the review
feedback from the earlier round. I gave the series only a fairly cursory
read, but I didn't see anything to complain about.
-Peff
next prev parent reply other threads:[~2026-10-14 10:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 23:43 hostname: includeIf condition — anyone already working on this? Isabella Caselli
2026-09-29 1:44 ` Jeff King
2026-09-29 12:14 ` Ignacio Encinas
2026-09-29 18:28 ` Jeff King
2026-09-29 19:55 ` Junio C Hamano
2026-10-02 1:52 ` Isabella Caselli
2026-10-12 1:58 ` [PATCH 0/3] Add hostname condition to includeIf Isabella Caselli
2026-10-12 1:58 ` [PATCH 1/3] var: add GIT_HOSTNAME Isabella Caselli
2026-10-12 1:58 ` [PATCH 2/3] t6500: get hostname from "git var" Isabella Caselli
2026-10-12 19:20 ` Junio C Hamano
2026-10-13 1:14 ` Isabella Caselli
2026-10-13 1:43 ` Junio C Hamano
2026-10-12 1:58 ` [PATCH 3/3] config: learn the "hostname:" includeIf condition Isabella Caselli
2026-10-12 19:24 ` Junio C Hamano
2026-10-14 10:31 ` Jeff King [this message]
2026-10-15 10:58 ` [PATCH v2 0/3] Add hostname condition to includeIf Isabella Caselli
2026-10-15 10:58 ` [PATCH v2 1/3] var: add GIT_HOSTNAME Isabella Caselli
2026-10-15 10:58 ` [PATCH v2 2/3] t6500: get hostname from "git var" Isabella Caselli
2026-10-15 10:58 ` [PATCH v2 3/3] config: learn the "hostname:" includeIf condition Isabella Caselli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261014103118.GA1356555@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=bellacaselli20@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ignacio@iencinas.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox