From: jyotishkumar725015@gmail.com
To: git@vger.kernel.org
Cc: jyotish kumar <jyotishkumar725015@gmail.com>
Subject: [PATCH] t1006: skip %(rest) test for whitespace in object names
Date: Mon, 26 Oct 2026 11:43:10 +0530 [thread overview]
Message-ID: <20261026061310.62950-1-jyotishkumar725015@gmail.com> (raw)
In-Reply-To: <CAGjZMyRF-hV8PMK2VBJT-9kzvgtQYP2EfYSMPjxSKmc2ZgscDw@mail.gmail.com>
From: jyotish kumar <jyotishkumar725015@gmail.com>
---
t/t1006-cat-file.sh | 27 ++++++++++++---------------
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git a/t/t1006-cat-file.sh b/t/t1006-cat-file.sh
index 72fc8acc61..47d9434bcc 100755
--- a/t/t1006-cat-file.sh
+++ b/t/t1006-cat-file.sh
@@ -183,21 +183,18 @@ $content"
test_cmp expect actual
'
- # FIXME: %(rest) is incompatible with object names that include whitespace,
- # e.g. HEAD:path/to/a/file with spaces. Use the resolved OID as input to
- # test this instead of the raw object name.
- if echo "$object_name" | grep -q " "; then
- test_rest=test_expect_failure
- else
- test_rest=test_expect_success
- fi
-
- $test_rest '--batch-check with %(rest)' '
- echo "$type this is some extra content" >expect &&
- echo "$object_name this is some extra content" |
- git cat-file --batch-check="%(objecttype) %(rest)" >actual &&
- test_cmp expect actual
- '
+ case "$object_name" in
+ *[[:space:]]*)
+ ;;
+ *)
+ test_expect_success '--batch-check with %(rest)' '
+ echo "$type this is some extra content" >expect &&
+ echo "$object_name this is some extra content" |
+ git cat-file --batch-check="%(objecttype) %(rest)" >actual &&
+ test_cmp expect actual
+ '
+ ;;
+ esac
test_expect_success '--batch-check with %(objectmode)' '
echo "$mode $oid" >expect &&
--
2.43.0
prev parent reply other threads:[~2026-10-26 6:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-24 6:47 [Discussion] t1006: testing %(rest) with object names containing whitespace jyotish kumar
2026-10-26 1:32 ` Jeff King
2026-10-26 3:41 ` Junio C Hamano
2026-10-26 4:56 ` jyotish kumar
2026-10-26 6:13 ` jyotishkumar725015 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261026061310.62950-1-jyotishkumar725015@gmail.com \
--to=jyotishkumar725015@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox