From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: jyotish kumar <jyotishkumar725015@gmail.com>, git@vger.kernel.org
Subject: Re: [Discussion] t1006: testing %(rest) with object names containing whitespace
Date: Sun, 25 Oct 2026 20:41:29 -0700 [thread overview]
Message-ID: <xmqqjyn5w2l2.fsf@gitster.g> (raw)
In-Reply-To: <20261026013254.GB3575069@coredump.intra.peff.net> (Jeff King's message of "Sun, 25 Oct 2026 21:32:54 -0400")
Jeff King <peff@peff.net> writes:
> So IMHO everything is working as designed, and there is nothing to fix
> in the code. But using test_expect_failure seems weird to me. It avoids
> the test suite announcing a failure, but it is not really a breakage to
> be fixed. A test with %(rest) and an object name with space should
> probably just be skipped. We _could_ run just those cases with the
> resolved id, but the point of that test is checking how %(rest) works
> with the name, so I don't know that it would be testing anything useful.
Yup, thanks for finding old (but not so old) discussion. We really
should have fixed the test including the fixme comment as we knew
already back then that there was nothing to fix.
Perhaps somebody involved in this discussion thread can volunteer to
do so this time?
next prev parent reply other threads:[~2026-10-26 3:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-24 6:47 [Discussion] t1006: testing %(rest) with object names containing whitespace jyotish kumar
2026-10-26 1:32 ` Jeff King
2026-10-26 3:41 ` Junio C Hamano [this message]
2026-10-26 4:56 ` jyotish kumar
2026-10-26 6:13 ` [PATCH] t1006: skip %(rest) test for whitespace in object names jyotishkumar725015
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqjyn5w2l2.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jyotishkumar725015@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox