Git development
 help / color / mirror / Atom feed
From: kerylefondji7@gmail.com
To: gitster@pobox.com
Cc: phillip.wood123@gmail.com, christian.couder@gmail.com,
	siddharthasthana31@gmail.com, git@vger.kernel.org,
	Keryle Fondji <kerylefondji7@gmail.com>
Subject: [PATCH v7 0/1] archive-zip: refactor 'path too long' error message
Date: Mon, 26 Oct 2026 20:28:02 +0100	[thread overview]
Message-ID: <20261026192803.1985-1-kerylefondji7@gmail.com> (raw)
In-Reply-To: <xmqotsm8qsdl.fsf@gitster.g>

From: Keryle Fondji <kerylefondji7@gmail.com>

This v7 addresses the feedback from Junio C Hamano and Phillip Wood regarding
commit structure, missing commit log message, and patch threading.

In previous attempts (like v5), the diff showed 4 deletions and 4 insertions
because it was compared against prior iteration attempts. Since this v7 is
flattened into a single clean commit applied directly on top of master, the
diff naturally shows 2 deletions (-) (removing the original master lines) and
4 insertions (+) (adding the complete Q_() structure with correct tab/space
alignments).

Regarding the mistakes in previous iterations:
- The commit message body was inadvertently omitted, which has now been fully
  restored.
- An incorrect Message-ID was used for threading (replying to an older
  reference instead of the proper discussion thread), which is also corrected.

Summary of changes in v7:
- Rebased as a single clean commit directly on top of master.
- Maintained the exact indentation approved in v5.
- Restored the full commit log message and proper Signed-off-by signature.
- Cleaned up unrelated modifications from the working directory.

Keryle Fondji (1):
  archive-zip: refactor 'path too long' error message to use Q_()

 archive-zip.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

-- 
2.53.0


  parent reply	other threads:[~2026-10-26 19:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <xmqotsm8qsdl.fsf@gitster.g>
2026-10-26 19:04 ` [PATCH v7 0/1] archive-zip: refactor 'path too long' error message kerylefondji7
2026-10-26 19:04   ` [PATCH v7 1/1] archive-zip: refactor 'path too long' error message to use Q_() kerylefondji7
2026-10-26 20:32     ` Junio C Hamano
2026-10-26 19:28 ` kerylefondji7 [this message]
2026-10-26 19:28   ` kerylefondji7
2026-10-27  8:50     ` [PATCH v7 1/1] archive-zip: replace _() with Q_() in path too long error kerylefondji7
2026-10-27 19:33       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261026192803.1985-1-kerylefondji7@gmail.com \
    --to=kerylefondji7@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=phillip.wood123@gmail.com \
    --cc=siddharthasthana31@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox