From: kerylefondji7@gmail.com
To: gitster@pobox.com
Cc: phillip.wood123@gmail.com, christian.couder@gmail.com,
siddharthasthana31@gmail.com, git@vger.kernel.org,
Keryle Fondji <kerylefondji7@gmail.com>
Subject: [PATCH v7 1/1] archive-zip: refactor 'path too long' error message to use Q_()
Date: Mon, 26 Oct 2026 20:28:03 +0100 [thread overview]
Message-ID: <20261026192803.1985-2-kerylefondji7@gmail.com> (raw)
In-Reply-To: <20261026192803.1985-1-kerylefondji7@gmail.com>
From: Keryle Fondji <kerylefondji7@gmail.com>
Replace _() with Q_() in the 'path too long' error message. Although
pathlen is always greater than 0xffff when this error is hit, Q_() is
required to support correct translation for languages that require
different plural forms depending on the count.
Signed-off-by: Keryle Fondji <kerylefondji7@gmail.com>
---
archive-zip.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/archive-zip.c b/archive-zip.c
index 6f73ca6d58..160efd878f 100644
--- a/archive-zip.c
+++ b/archive-zip.c
@@ -328,8 +328,10 @@ static int write_zip_entry(struct archiver_args *args,
}
if (pathlen > 0xffff) {
- return error(_("path too long (%d chars, SHA1: %s): %s"),
- (int)pathlen, oid_to_hex(oid), path);
+ return error(Q_("path too long (%d char, SHA1: %s): %s",
+ "path too long (%d chars, SHA1: %s): %s",
+ pathlen),
+ (int)pathlen, oid_to_hex(oid), path);
}
if (S_ISDIR(mode) || S_ISGITLINK(mode)) {
--
2.53.0
next prev parent reply other threads:[~2026-10-26 19:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <xmqotsm8qsdl.fsf@gitster.g>
2026-10-26 19:04 ` [PATCH v7 0/1] archive-zip: refactor 'path too long' error message kerylefondji7
2026-10-26 19:04 ` [PATCH v7 1/1] archive-zip: refactor 'path too long' error message to use Q_() kerylefondji7
2026-10-26 20:32 ` Junio C Hamano
2026-10-26 19:28 ` [PATCH v7 0/1] archive-zip: refactor 'path too long' error message kerylefondji7
2026-10-26 19:28 ` kerylefondji7 [this message]
2026-10-27 8:50 ` [PATCH v7 1/1] archive-zip: replace _() with Q_() in path too long error kerylefondji7
2026-10-27 19:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261026192803.1985-2-kerylefondji7@gmail.com \
--to=kerylefondji7@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phillip.wood123@gmail.com \
--cc=siddharthasthana31@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox