From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/4] ident: remove unused author_ident_sufficiently_given()
Date: Fri, 30 Oct 2026 14:22:11 -0400 [thread overview]
Message-ID: <20261030182211.GC7582@coredump.intra.peff.net> (raw)
In-Reply-To: <20261030173956.585250-2-gitster@pobox.com>
On Fri, Oct 30, 2026 at 10:39:53AM -0700, Junio C Hamano wrote:
> A pair of functions {author,committer}_ident_sufficiently_given()
> were created to replace user_ident_explicitly_given() in d6991ceedc
> (ident: keep separate "explicit" flags for author and committer,
> 2012-11-14).
>
> But author_ident_sufficiently_given() is never used in our history.
> We only check if committer ident is sufficiently given and use it to
> nudge the user to set user.{name,email} configuration variables.
>
> Remove the unused author_ident_sufficiently_given() function.
Makes sense. I think I must have just added it for symmetry with the
committer one, but I agree it was never used. It almost looks like we
could drop author_ident_explicitly_given, too, which appears to be
write-only after this patch. But it is somewhat subtly used via
set_env_if() and prepare_fallback_ident(). So this seems like an obvious
cleanup and a good stopping point.
-Peff
next prev parent reply other threads:[~2026-10-30 18:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 17:39 [PATCH 0/4] mark symbols that are unnecessarily public static Junio C Hamano
2026-10-30 17:39 ` [PATCH 1/4] ident: remove unused author_ident_sufficiently_given() Junio C Hamano
2026-10-30 18:22 ` Jeff King [this message]
2026-10-30 17:39 ` [PATCH 2/4] add -i: hide init/clear_add_i_state() functions Junio C Hamano
2026-10-30 17:39 ` [PATCH 3/4] read-cache: hide refresh_cache_entry() Junio C Hamano
2026-10-30 18:25 ` Jeff King
2026-10-30 17:39 ` [PATCH 4/4] unpack-trees: hide verify_uptodate() Junio C Hamano
2026-10-30 18:26 ` [PATCH 0/4] mark symbols that are unnecessarily public static Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261030182211.GC7582@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox