From: Aniket Gupta <aniketgupta3001@gmail.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Junio C Hamano <gitster@pobox.com>,
Derrick Stolee <stolee@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH v3 0/3] bundle-uri: do not die on unresolvable relative URIs
Date: Mon, 9 Nov 2026 10:56:53 +0000 [thread overview]
Message-ID: <20261109105653.397878-1-aniketgupta3001@gmail.com> (raw)
In-Reply-To: <avGR422rPHr1Orv5@pks.im>
> Huh, where does this quote come from? It's certainly not part of the
> mail you reply to. Also, you stripped all necessary context for somebody
> to know what this was even talking about.
Apologies. That line is from Stolee's review of patch 2. I replied on the wrong mail. I have answered on patch 2 thread with context: https://lore.kernel.org/git/20261109103916.397673-1-aniketgupta3001@gmail.com/
> But the other part of patch 2 should definitely be retained in my
> opinion, because printing an error with the URL after we have trimmed
> "../" components off of it is just plain not useful.
Understood. I will keep that part.
prev parent reply other threads:[~2026-11-09 10:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 15:28 [PATCH v3 0/3] bundle-uri: do not die on unresolvable relative URIs Aniket Gupta
2026-11-05 15:28 ` [PATCH v3 1/3] remote: add relative_url_gently() Aniket Gupta
2026-11-06 14:36 ` Derrick Stolee
2026-11-05 15:28 ` [PATCH v3 2/3] remote: do not show credentials when relative_url() fails Aniket Gupta
2026-11-06 14:43 ` Derrick Stolee
2026-11-06 19:15 ` Junio C Hamano
2026-11-09 10:39 ` Aniket Gupta
2026-11-05 15:28 ` [PATCH v3 3/3] bundle-uri: do not die on unresolvable relative URIs Aniket Gupta
2026-11-06 14:51 ` Derrick Stolee
2026-11-06 14:57 ` [PATCH v3 0/3] " Derrick Stolee
2026-11-06 17:25 ` Aniket Gupta
2026-11-09 9:26 ` Patrick Steinhardt
2026-11-09 10:56 ` Aniket Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261109105653.397878-1-aniketgupta3001@gmail.com \
--to=aniketgupta3001@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ps@pks.im \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox