Re: [PATCH v3 0/3] bundle-uri: do not die on unresolvable relative URIs

[Patrick Steinhardt <ps@pks.im>]

On Fri, Nov 06, 2026 at 05:25:33PM +0000, Aniket Gupta wrote:
> Hi Stolee,
> 
> Thanks for the review.
> 
> > I'm less convinced on this factor.

Huh, where does this quote come from? It's certainly not part of the
mail you reply to. Also, you stripped all necessary context for somebody
to know what this was even talking about.

> Fair point. I tried it with a password in the remote URL but the "failed
> to download bundle from URI" warning prints it as is. I think this patch
> will only cover this one message. The reason I did it is that git
> already hides the password when it shows a remote URL. For eg. in the
> "From" line of fetch. It is a separate patch so it is easy to drop if
> you and Patrick think it is not worth it.

I don't have a strong opinion on whether or not we should strip
credentials. It feels like the right thing to do, but I trust Stolee's
input here.

But the other part of patch 2 should definitely be retained in my
opinion, because printing an error with the URL after we have trimmed
"../" components off of it is just plain not useful. There is no way for
the user to tell how the URL is broken because we may have already
stripped the relevant components here.

Patrick