Git development
 help / color / mirror / Atom feed
From: Jasper Mayone <me@jaspermayone.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, phillip.wood123@gmail.com,
	sunshine@sunshineco.com, kristofferhaugsbakk@fastmail.com,
	ben.knoble@gmail.com, haraldnordgren@gmail.com,
	Jasper Mayone <me@jaspermayone.com>
Subject: [PATCH v5 0/5] worktree: treat a branch being rebased or bisected as checked out
Date: Wed, 11 Nov 2026 10:28:05 -0500	[thread overview]
Message-ID: <20261111152811.99986-1-me@jaspermayone.com> (raw)
In-Reply-To: <20261102182930.3511-1-me@jaspermayone.com>

While a worktree is rebasing or bisecting a branch, its HEAD is
detached. "git worktree add" and "git branch -d" already treat the
branch as checked out there, but "git worktree remove" deletes such a
worktree when its files are clean, and %(worktreepath) and "git
branch" do not show which worktree has the branch.

Patch 1 makes "git worktree remove" refuse a worktree in the middle of
an operation unless --force is given. Patch 2 documents how to read
%(worktreepath) safely. Patch 3 makes %(worktreepath) name the
worktree that is rebasing or bisecting a branch. Patch 4 adds
%(currentworktree), and patch 5 uses it so that "git branch" does not
mark that branch with "+" in the worktree that is rebasing it.

Changes since v4 [1]:

 * Patch 1: each item in the list of cases that need --force is now a
   complete sentence, and all the commands are in the same font, as
   Phillip asked. Ben was happy with the old wording, and I hope this
   suits both of you.

 * Patch 2: no change.

 * Patch 3: branch.c records the branches in a map, so
   branch_checked_out_worktree() is one map lookup in place of a loop
   over every worktree for each ref.

 * Patch 4 is new. It adds %(currentworktree), which Phillip
   suggested. It uses a second map in branch.c for the branches that
   the current worktree has.

 * Patch 5 replaces v4's patch 4. The default "git branch" format now
   uses %(currentworktree), so print_ref_list() is unchanged and the
   patch is a few lines in build_format().

[1] https://lore.kernel.org/git/20261102182930.3511-1-me@jaspermayone.com/

Jasper Mayone (5):
  worktree remove: refuse a worktree in the middle of an operation
  doc: for-each-ref: say how to read %(worktreepath) safely
  ref-filter: name the worktree of a branch being rebased or bisected
  ref-filter: add %(currentworktree)
  branch: do not mark the branch the current worktree is rebasing

 Documentation/git-branch.adoc       |  6 +-
 Documentation/git-for-each-ref.adoc | 19 +++++-
 Documentation/git-worktree.adoc     | 17 +++--
 branch.c                            | 33 ++++++++--
 branch.h                            | 16 +++++
 builtin/branch.c                    | 10 ++-
 builtin/worktree.c                  | 37 ++++++++++-
 ref-filter.c                        | 84 ++++---------------------
 t/t2403-worktree-move.sh            | 94 ++++++++++++++++++++++++++++
 t/t3203-branch-output.sh            | 49 +++++++++++++++
 t/t6302-for-each-ref-filter.sh      | 97 +++++++++++++++++++++++++++++
 11 files changed, 373 insertions(+), 89 deletions(-)

Range-diff against v4:
1:  bca692b844 ! 1:  69668bf9b1 worktree remove: refuse a worktree in the middle of an operation
    @@ Documentation/git-worktree.adoc: the new working tree location.
     -with submodules can be removed with `--force`. The main worktree cannot be
     -removed.
     +Remove a worktree. The main worktree cannot be removed. Without
    -+`--force`, a worktree is not removed when:
    ++`--force`, a worktree is not removed in these cases:
     ++
     +--
    -+* it has untracked files or modifications in tracked files,
    -+* it has submodules, or
    -+* it is in the middle of a rebase, a `git am` session, a bisect, a
    -+  cherry-pick or a revert, because removing it loses the state of that
    -+  operation.
    ++* The worktree has untracked files or modifications in tracked files.
    ++* The worktree has submodules.
    ++* The worktree is in the middle of a `git rebase`, `git am`,
    ++  `git bisect`, `git cherry-pick` or `git revert`. Removing the
    ++  worktree would lose the state of that operation.
     +--
      
      `repair [<path>...]`::
2:  39eb92d441 = 2:  35035d30e2 doc: for-each-ref: say how to read %(worktreepath) safely
3:  990a19fd11 ! 3:  4484dfff22 ref-filter: name the worktree of a branch being rebased or bisected
    @@ Commit message
     
         branch.c already knows the answer, as prepare_checked_out_branches()
         records the branch that each worktree has checked out, is rebasing or
    -    is bisecting. Add branch_checked_out_worktree() to look a branch up in
    -    that list, and use it for %(worktreepath) in place of the map that
    -    ref-filter.c builds from the HEAD of each worktree.
    +    is bisecting. Record those branches in a map as well, add
    +    branch_checked_out_worktree() to look a branch up in it, and use that
    +    for %(worktreepath) in place of the map that ref-filter.c builds from
    +    the HEAD of each worktree.
     
         The new function skips the branches that "rebase --update-refs" will
         update. branch_checked_out() includes them, so that they cannot be
    @@ Documentation/git-for-each-ref.adoc: but if used together the last option is sel
      	use one of the quoting options such as `--shell`, or follow
     
      ## branch.c ##
    +@@ branch.c: int validate_branchname(const char *name, struct strbuf *ref)
    + 
    + static int initialized_checked_out_branches;
    + static struct strmap current_checked_out_branches = STRMAP_INIT;
    ++/* Like current_checked_out_branches, without the "update-ref" branches. */
    ++static struct strmap checked_out_worktrees = STRMAP_INIT;
    + 
    + enum branch_checkout_kind {
    + 	BRANCH_CHECKOUT_KIND_CHECKOUT,
    +@@ branch.c: static void register_checked_out_branch(const char *prefix, const char *name,
    + 	checked_out_branches_nr++;
    + 
    + 	strmap_put(&current_checked_out_branches, refname, path_copy);
    ++	if (kind != BRANCH_CHECKOUT_KIND_UPDATE_REF)
    ++		strmap_put(&checked_out_worktrees, refname, path_copy);
    + }
    + 
    + static void prepare_checked_out_branches(void)
     @@ branch.c: const char *branch_checked_out(const char *refname)
      	return strmap_get(&current_checked_out_branches, refname);
      }
      
     +const char *branch_checked_out_worktree(const char *refname)
     +{
    -+	const char *path = NULL;
    -+
     +	prepare_checked_out_branches();
    -+	for (size_t i = 0; i < checked_out_branches_nr; i++) {
    -+		if (checked_out_branches[i].kind != BRANCH_CHECKOUT_KIND_UPDATE_REF &&
    -+		    !strcmp(refname, checked_out_branches[i].refname))
    -+			path = checked_out_branches[i].path;
    -+	}
    -+	return path;
    ++	return strmap_get(&checked_out_worktrees, refname);
     +}
     +
      const char *branch_bisecting(const char *refname)
4:  56e29c448f ! 4:  944ce70324 branch: do not mark the branch the current worktree is rebasing
    @@ Metadata
     Author: Jasper Mayone <me@jaspermayone.com>
     
      ## Commit message ##
    -    branch: do not mark the branch the current worktree is rebasing
    +    ref-filter: add %(currentworktree)
     
    -    Since the previous commit, "git branch" marks a branch with "+" when a
    -    worktree is rebasing or bisecting it. In that worktree itself, the
    -    list already starts with "* (no branch, rebasing topic)", so the
    -    "+ topic" line below it says the same thing twice.
    +    %(worktreepath) names the worktree that has a branch checked out, or
    +    is rebasing or bisecting it, but a format cannot tell if that worktree
    +    is the current one. Comparing %(worktreepath) with a fixed path in
    +    %(if:equals=...) does not work for every path, because a ")" ends the
    +    atom.
     
    -    The default format cannot tell that apart: %(worktreepath) gives the
    -    same path either way, and comparing it with %(if:equals=...) is not
    -    safe because a path, or a branch name, can contain the ")" that ends
    -    the atom. So build a second format that has no "+" marker and no
    -    "(path)" for -vv, and use it for each branch that
    -    branch_checked_out_worktree() maps to the current worktree. A branch
    -    that is checked out normally in the current worktree also gets that
    -    format, but %(HEAD) still marks it with "*" and -vv already hides
    -    its path, so its output does not change.
    +    Add %(currentworktree), which gives the path of the current worktree
    +    when that worktree has the branch, and an empty string otherwise.
    +    branch.c records these branches when it reads the worktrees, in a
    +    second map next to the one that %(worktreepath) uses, so the lookup is
    +    one map lookup per ref.
     
    -    To pick a format for each branch, print_ref_list() now formats the
    -    branches itself in place of print_formatted_ref_array(), keeping
    -    --omit-empty. A format given with --format is used for every branch,
    -    as before.
    +    The next commit uses it in "git branch".
     
         Suggested-by: Phillip Wood <phillip.wood123@gmail.com>
         Signed-off-by: Jasper Mayone <me@jaspermayone.com>
     
    - ## builtin/branch.c ##
    -@@ builtin/branch.c: static const char *quote_literal_for_format(const char *s)
    - 	return buf.buf;
    - }
    + ## Documentation/git-for-each-ref.adoc ##
    +@@ Documentation/git-for-each-ref.adoc: but if used together the last option is selected.
    + 	the `NUL` after the path and then for the `LF` that ends each
    + 	record.
      
    --static char *build_format(struct ref_filter *filter, int maxwidth, const char *remote_prefix)
    -+/*
    -+ * With "show_worktree" unset, the format does not mark a branch that is
    -+ * checked out in a worktree, nor show the path of that worktree. It is
    -+ * used for a branch that the current worktree is rebasing or bisecting,
    -+ * because the "(no branch, ...)" line already names it.
    -+ */
    -+static char *build_format(struct ref_filter *filter, int maxwidth,
    -+			  const char *remote_prefix, int show_worktree)
    - {
    - 	struct strbuf fmt = STRBUF_INIT;
    - 	struct strbuf local = STRBUF_INIT;
    - 	struct strbuf remote = STRBUF_INIT;
    - 
    --	strbuf_addf(&local, "%%(if)%%(HEAD)%%(then)* %s%%(else)%%(if)%%(worktreepath)%%(then)+ %s%%(else)  %s%%(end)%%(end)",
    --			branch_get_color(BRANCH_COLOR_CURRENT),
    --			branch_get_color(BRANCH_COLOR_WORKTREE),
    --			branch_get_color(BRANCH_COLOR_LOCAL));
    -+	if (show_worktree)
    -+		strbuf_addf(&local, "%%(if)%%(HEAD)%%(then)* %s%%(else)%%(if)%%(worktreepath)%%(then)+ %s%%(else)  %s%%(end)%%(end)",
    -+			    branch_get_color(BRANCH_COLOR_CURRENT),
    -+			    branch_get_color(BRANCH_COLOR_WORKTREE),
    -+			    branch_get_color(BRANCH_COLOR_LOCAL));
    -+	else
    -+		strbuf_addf(&local, "%%(if)%%(HEAD)%%(then)* %s%%(else)  %s%%(end)",
    -+			    branch_get_color(BRANCH_COLOR_CURRENT),
    -+			    branch_get_color(BRANCH_COLOR_LOCAL));
    - 	strbuf_addf(&remote, "  %s",
    - 		    branch_get_color(BRANCH_COLOR_REMOTE));
    - 
    -@@ builtin/branch.c: static char *build_format(struct ref_filter *filter, int maxwidth, const char *r
    - 
    - 		if (filter->verbose > 1)
    - 		{
    --			strbuf_addf(&local, "%%(if:notequals=*)%%(HEAD)%%(then)%%(if)%%(worktreepath)%%(then)(%s%%(worktreepath)%s) %%(end)%%(end)",
    --				    branch_get_color(BRANCH_COLOR_WORKTREE), branch_get_color(BRANCH_COLOR_RESET));
    -+			if (show_worktree)
    -+				strbuf_addf(&local, "%%(if:notequals=*)%%(HEAD)%%(then)%%(if)%%(worktreepath)%%(then)(%s%%(worktreepath)%s) %%(end)%%(end)",
    -+					    branch_get_color(BRANCH_COLOR_WORKTREE), branch_get_color(BRANCH_COLOR_RESET));
    - 			strbuf_addf(&local, "%%(if)%%(upstream)%%(then)[%s%%(upstream:short)%s%%(if)%%(upstream:track)"
    - 				    "%%(then): %%(upstream:track,nobracket)%%(end)] %%(end)%%(contents:subject)",
    - 				    branch_get_color(BRANCH_COLOR_UPSTREAM), branch_get_color(BRANCH_COLOR_RESET));
    -@@ builtin/branch.c: static char *build_format(struct ref_filter *filter, int maxwidth, const char *r
    - 	return strbuf_detach(&fmt, NULL);
    - }
    - 
    -+static char *current_worktree_path(void)
    -+{
    -+	struct worktree **worktrees = get_worktrees(the_repository);
    -+	char *path = NULL;
    ++`currentworktree`::
    ++	The absolute path to the current worktree, if the ref is checked
    ++	out there, in the same sense as for `worktreepath`. Empty string
    ++	otherwise, also when the ref is checked out only in other
    ++	worktrees. Use it with `%(if)` to treat the current worktree
    ++	differently from the others.
     +
    -+	for (size_t i = 0; worktrees[i]; i++) {
    -+		if (worktrees[i]->is_current) {
    -+			path = xstrdup(worktrees[i]->path);
    -+			break;
    -+		}
    -+	}
    -+	free_worktrees(worktrees);
    -+	return path;
    -+}
    -+
    -+/*
    -+ * Is "refname" checked out in the worktree at "here", or is that
    -+ * worktree rebasing or bisecting it?
    -+ */
    -+static int checked_out_here(const char *refname, const char *here)
    -+{
    -+	const char *path = branch_checked_out_worktree(refname);
    -+
    -+	return path && !strcmp(path, here);
    -+}
    -+
    - static void print_ref_list(struct ref_filter *filter, struct ref_sorting *sorting,
    - 			   struct ref_format *format, struct string_list *output)
    - {
    -@@ builtin/branch.c: static void print_ref_list(struct ref_filter *filter, struct ref_sorting *sortin
    - 	int maxwidth = 0;
    - 	const char *remote_prefix = "";
    - 	char *to_free = NULL;
    -+	struct ref_format here_format = REF_FORMAT_INIT;
    -+	char *here_to_free = NULL, *here = NULL;
    -+	struct strbuf out = STRBUF_INIT, err = STRBUF_INIT;
    - 
    - 	/*
    - 	 * If we are listing more than just remote branches,
    -@@ builtin/branch.c: static void print_ref_list(struct ref_filter *filter, struct ref_sorting *sortin
    - 	if (filter->verbose)
    - 		maxwidth = calc_maxwidth(&array, strlen(remote_prefix));
    - 
    --	if (!format->format)
    --		format->format = to_free = build_format(filter, maxwidth, remote_prefix);
    -+	if (!format->format) {
    -+		format->format = to_free = build_format(filter, maxwidth,
    -+							remote_prefix, 1);
    -+		here = current_worktree_path();
    -+		here_format = *format;
    -+		here_format.format = here_to_free = build_format(filter, maxwidth,
    -+								 remote_prefix, 0);
    -+	}
    - 	format->use_color = branch_use_color;
    -+	here_format.use_color = branch_use_color;
    - 
    --	if (verify_ref_format(format))
    -+	if (verify_ref_format(format) ||
    -+	    (here && verify_ref_format(&here_format)))
    - 		die(_("unable to parse format string"));
    - 
    - 	filter_ahead_behind(the_repository, &array);
    - 	ref_array_sort(sorting, &array);
    - 
    --	if (column_active(colopts)) {
    --		struct strbuf out = STRBUF_INIT, err = STRBUF_INIT;
    --
    -+	if (column_active(colopts))
    - 		assert(!filter->verbose && "--column and --verbose are incompatible");
    - 
    --		for (i = 0; i < array.nr; i++) {
    --			strbuf_reset(&err);
    --			strbuf_reset(&out);
    --			if (format_ref_array_item(array.items[i], format, &out, &err))
    --				die("%s", err.buf);
    -+	for (i = 0; i < array.nr; i++) {
    -+		struct ref_array_item *item = array.items[i];
    -+		struct ref_format *f = format;
    - 
    -+		if (here && checked_out_here(item->refname, here))
    -+			f = &here_format;
    -+
    -+		strbuf_reset(&err);
    -+		strbuf_reset(&out);
    -+		if (format_ref_array_item(item, f, &out, &err))
    -+			die("%s", err.buf);
    -+
    -+		if (column_active(colopts))
    - 			/* format to a string_list to let print_columns() do its job */
    - 			string_list_append(output, out.buf);
    -+		else if (out.len || !format->array_opts.omit_empty) {
    -+			fwrite(out.buf, 1, out.len, stdout);
    -+			putchar('\n');
    - 		}
    --
    --		strbuf_release(&err);
    --		strbuf_release(&out);
    --	} else {
    --		print_formatted_ref_array(&array, format);
    - 	}
    - 
    -+	strbuf_release(&err);
    -+	strbuf_release(&out);
    - 	ref_array_clear(&array);
    - 	free(to_free);
    -+	free(here_to_free);
    -+	free(here);
    - }
    - 
    - static void print_current_branch_name(void)
    + `ahead-behind:<commit-ish>`::
    + 	Two integers, separated by a space, demonstrating the number of
    + 	commits ahead and behind, respectively, when comparing the output
     
    - ## t/t3203-branch-output.sh ##
    -@@ t/t3203-branch-output.sh: test_expect_success 'branch being rebased in a worktree is marked' '
    + ## branch.c ##
    +@@ branch.c: static int initialized_checked_out_branches;
    + static struct strmap current_checked_out_branches = STRMAP_INIT;
    + /* Like current_checked_out_branches, without the "update-ref" branches. */
    + static struct strmap checked_out_worktrees = STRMAP_INIT;
    ++/* The subset of checked_out_worktrees that the current worktree has. */
    ++static struct strmap current_worktree_branches = STRMAP_INIT;
    + 
    + enum branch_checkout_kind {
    + 	BRANCH_CHECKOUT_KIND_CHECKOUT,
    +@@ branch.c: static struct checked_out_branch *checked_out_branches;
    + static size_t checked_out_branches_alloc, checked_out_branches_nr;
    + 
    + static void register_checked_out_branch(const char *prefix, const char *name,
    +-					const char *path,
    ++					const struct worktree *wt,
    + 					enum branch_checkout_kind kind)
    + {
    + 	char *refname = xstrfmt("%s%s", prefix, name);
    +-	char *path_copy = xstrdup(path);
    ++	char *path_copy = xstrdup(wt->path);
    + 
    + 	ALLOC_GROW(checked_out_branches, checked_out_branches_nr + 1,
    + 		   checked_out_branches_alloc);
    +@@ branch.c: static void register_checked_out_branch(const char *prefix, const char *name,
    + 	checked_out_branches_nr++;
    + 
    + 	strmap_put(&current_checked_out_branches, refname, path_copy);
    +-	if (kind != BRANCH_CHECKOUT_KIND_UPDATE_REF)
    ++	if (kind != BRANCH_CHECKOUT_KIND_UPDATE_REF) {
    + 		strmap_put(&checked_out_worktrees, refname, path_copy);
    ++		if (wt->is_current)
    ++			strmap_put(&current_worktree_branches, refname, path_copy);
    ++	}
    + }
    + 
    + static void prepare_checked_out_branches(void)
    +@@ branch.c: static void prepare_checked_out_branches(void)
    + 			continue;
    + 
    + 		if (wt->head_ref) {
    +-			register_checked_out_branch("", wt->head_ref, wt->path,
    ++			register_checked_out_branch("", wt->head_ref, wt,
    + 						    BRANCH_CHECKOUT_KIND_CHECKOUT);
    + 		}
    + 
    +@@ branch.c: static void prepare_checked_out_branches(void)
    + 		    (state.rebase_in_progress || state.rebase_interactive_in_progress) &&
    + 		    state.branch) {
    + 			register_checked_out_branch("refs/heads/", state.branch,
    +-						    wt->path,
    ++						    wt,
    + 						    BRANCH_CHECKOUT_KIND_REBASE);
    + 		}
    + 		wt_status_state_free_buffers(&state);
    +@@ branch.c: static void prepare_checked_out_branches(void)
    + 		    state.bisecting_from) {
    + 			register_checked_out_branch("refs/heads/",
    + 						    state.bisecting_from,
    +-						    wt->path,
    ++						    wt,
    + 						    BRANCH_CHECKOUT_KIND_BISECT);
    + 		}
    + 		wt_status_state_free_buffers(&state);
    +@@ branch.c: static void prepare_checked_out_branches(void)
    + 			struct string_list_item *item;
    + 			for_each_string_list_item(item, &update_refs) {
    + 				register_checked_out_branch("", item->string,
    +-							    wt->path,
    ++							    wt,
    + 							    BRANCH_CHECKOUT_KIND_UPDATE_REF);
    + 			}
    + 			string_list_clear(&update_refs, 1);
    +@@ branch.c: const char *branch_checked_out_worktree(const char *refname)
    + 	return strmap_get(&checked_out_worktrees, refname);
    + }
    + 
    ++const char *branch_checked_out_current_worktree(const char *refname)
    ++{
    ++	prepare_checked_out_branches();
    ++	return strmap_get(&current_worktree_branches, refname);
    ++}
    ++
    + const char *branch_bisecting(const char *refname)
    + {
    + 	prepare_checked_out_branches();
    +
    + ## branch.h ##
    +@@ branch.h: const char *branch_checked_out(const char *refname);
    +  */
    + const char *branch_checked_out_worktree(const char *refname);
    + 
    ++/*
    ++ * Like branch_checked_out_worktree(), but only for the current
    ++ * worktree: return its path if it has the branch 'refname' checked
    ++ * out, or is rebasing or bisecting it. Otherwise return NULL.
    ++ */
    ++const char *branch_checked_out_current_worktree(const char *refname);
    ++
    + /*
    +  * If the branch at 'refname' is currently used for bisecting in a
    +  * worktree, then return the path to that worktree.
    +
    + ## ref-filter.c ##
    +@@ ref-filter.c: enum atom_type {
    + 	ATOM_HEAD,
    + 	ATOM_COLOR,
    + 	ATOM_WORKTREEPATH,
    ++	ATOM_CURRENTWORKTREE,
    + 	ATOM_ALIGN,
    + 	ATOM_END,
    + 	ATOM_IF,
    +@@ ref-filter.c: static struct {
    + 	[ATOM_HEAD] = { "HEAD", SOURCE_NONE, FIELD_STR, head_atom_parser },
    + 	[ATOM_COLOR] = { "color", SOURCE_NONE, FIELD_STR, color_atom_parser },
    + 	[ATOM_WORKTREEPATH] = { "worktreepath", SOURCE_NONE },
    ++	[ATOM_CURRENTWORKTREE] = { "currentworktree", SOURCE_NONE },
    + 	[ATOM_ALIGN] = { "align", SOURCE_NONE, FIELD_STR, align_atom_parser },
    + 	[ATOM_END] = { "end", SOURCE_NONE },
    + 	[ATOM_IF] = { "if", SOURCE_NONE, FIELD_STR, if_atom_parser },
    +@@ ref-filter.c: static int populate_value(struct ref_array_item *ref, struct strbuf *err)
    + 				v->s = xstrdup("");
    + 			continue;
    + 		}
    ++		else if (atom_type == ATOM_CURRENTWORKTREE) {
    ++			const char *path = NULL;
    ++
    ++			if (ref->kind == FILTER_REFS_BRANCHES)
    ++				path = branch_checked_out_current_worktree(ref->refname);
    ++			v->s = xstrdup(path ? path : "");
    ++			continue;
    ++		}
    + 		else if (atom_type == ATOM_SYMREF)
    + 			refname = get_symref(atom, ref);
    + 		else if (atom_type == ATOM_UPSTREAM) {
    +
    + ## t/t6302-for-each-ref-filter.sh ##
    +@@ t/t6302-for-each-ref-filter.sh: test_expect_success 'worktree atom ignores the HEAD of a bare repository' '
      	test_cmp expect actual
      '
      
    -+test_expect_success 'branch being rebased is not marked in its own worktree' '
    -+	test_when_finished "git -C rebase_dir rebase --abort; rm -rf rebase_dir; git worktree prune; git branch -D rebasing" &&
    -+	git worktree add -b rebasing rebase_dir branch-two &&
    -+	(
    -+		cd rebase_dir &&
    -+		git commit --allow-empty -m rebase-me &&
    -+		test_must_fail git rebase -f -x false HEAD~1 &&
    -+		git branch --list rebasing >actual &&
    -+		echo "  rebasing" >expect &&
    -+		test_cmp expect actual &&
    -+		git branch -vv --list rebasing >actual &&
    -+		test_grep ! "$(pwd)" actual &&
    -+		git branch >actual &&
    -+		test_grep "^\* (no branch, rebasing rebasing)" actual
    -+	)
    ++test_expect_success 'currentworktree atom' '
    ++	test_when_finished "git -C current rebase --abort; rm -rf current; git worktree prune; git branch -D current" &&
    ++	git worktree add -b current current main &&
    ++	git -C current commit --allow-empty -m rebase-me &&
    ++	test_must_fail git -C current rebase -f -x false main &&
    ++	git for-each-ref --format="%(refname:short) [%(currentworktree)]" \
    ++		refs/heads/main refs/heads/current >actual &&
    ++	cat >expect <<-EOF &&
    ++	current []
    ++	main [$(pwd)]
    ++	EOF
    ++	test_cmp expect actual &&
    ++	git -C current for-each-ref --format="%(refname:short) [%(currentworktree)]" \
    ++		refs/heads/main refs/heads/current >actual &&
    ++	cat >expect <<-EOF &&
    ++	current [$(pwd)/current]
    ++	main []
    ++	EOF
    ++	test_cmp expect actual
     +'
     +
    - test_expect_success 'branch being bisected in a worktree is marked' '
    - 	test_when_finished "git -C bisect_dir bisect reset; rm -rf bisect_dir; git worktree prune; git branch -D bisecting" &&
    - 	git worktree add -b bisecting bisect_dir branch-two &&
    -@@ t/t3203-branch-output.sh: test_expect_success 'branch being bisected in a worktree is marked' '
    - 		git commit --allow-empty -m bisect-one &&
    - 		git commit --allow-empty -m bisect-two &&
    - 		git bisect start HEAD HEAD~2 &&
    --		test_must_fail git symbolic-ref -q HEAD
    -+		test_must_fail git symbolic-ref -q HEAD &&
    -+		git branch --list bisecting >actual &&
    -+		echo "  bisecting" >expect &&
    -+		test_cmp expect actual
    - 	) &&
    - 	git branch --list bisecting >actual &&
    - 	echo "+ bisecting" >expect &&
    + test_expect_success 'start after with empty value' '
    + 	cat >expect <<-\EOF &&
    + 	refs/heads/main
-:  ---------- > 5:  4177c84d31 branch: do not mark the branch the current worktree is rebasing
-- 
2.56.0


  parent reply	other threads:[~2026-11-11 15:28 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-21 17:33 [RFC PATCH 0/1] worktree list: add --merged and --no-merged Jasper Mayone
2026-10-21 17:33 ` [RFC PATCH 1/1] " Jasper Mayone
2026-10-23 18:30   ` Junio C Hamano
2026-10-24  6:25     ` Eric Sunshine
2026-10-24 16:53       ` [PATCH v2] worktree list: add --branch to select worktrees by branch Jasper Mayone
2026-10-25 14:47         ` Phillip Wood
2026-10-26 11:02           ` Phillip Wood
2026-10-28  6:02           ` Eric Sunshine
2026-10-28 15:27             ` Junio C Hamano
2026-10-28 11:32         ` Kristoffer Haugsbakk
2026-10-29  4:46           ` Jasper Mayone
2026-10-29  5:01             ` Eric Sunshine
2026-10-29 11:14             ` Phillip Wood
2026-10-29 14:23               ` Ben Knoble
2026-10-29 16:10                 ` Phillip Wood
2026-10-30 14:21         ` [PATCH 0/2] worktree: treat a branch being rebased or bisected as checked out Jasper Mayone
2026-10-30 14:21           ` [PATCH 1/2] worktree remove: refuse a worktree in the middle of a rebase or bisect Jasper Mayone
2026-11-02 14:07             ` Phillip Wood
2026-11-02 17:57               ` Jasper Mayone
2026-10-30 14:21           ` [PATCH 2/2] ref-filter: name the worktree of a branch being rebased or bisected Jasper Mayone
2026-11-02 14:06             ` Phillip Wood
2026-11-02 17:57               ` Jasper Mayone
2026-10-30 22:55           ` [PATCH 0/2] worktree: treat a branch being rebased or bisected as checked out Junio C Hamano
2026-10-30 23:06             ` Jasper Mayone
2026-11-02 18:29           ` [PATCH v4 0/4] " Jasper Mayone
2026-11-02 18:29             ` [PATCH v4 1/4] worktree remove: refuse a worktree in the middle of an operation Jasper Mayone
2026-11-10 16:47               ` Phillip Wood
2026-11-10 17:09                 ` Ben Knoble
2026-11-02 18:29             ` [PATCH v4 2/4] doc: for-each-ref: say how to read %(worktreepath) safely Jasper Mayone
2026-11-09 12:36               ` D. Ben Knoble
2026-11-09 15:10                 ` Phillip Wood
2026-11-09 17:27                   ` Ben Knoble
2026-11-09 20:17                     ` Junio C Hamano
2026-11-10 16:47               ` Phillip Wood
2026-11-02 18:29             ` [PATCH v4 3/4] ref-filter: name the worktree of a branch being rebased or bisected Jasper Mayone
2026-11-10 16:47               ` Phillip Wood
2026-11-02 18:29             ` [PATCH v4 4/4] branch: do not mark the branch the current worktree is rebasing Jasper Mayone
2026-11-10 16:45               ` Phillip Wood
2026-11-10 16:49             ` [PATCH v4 0/4] worktree: treat a branch being rebased or bisected as checked out Phillip Wood
2026-11-11 15:28             ` Jasper Mayone [this message]
2026-11-11 15:28               ` [PATCH v5 1/5] worktree remove: refuse a worktree in the middle of an operation Jasper Mayone
2026-11-11 15:28               ` [PATCH v5 2/5] doc: for-each-ref: say how to read %(worktreepath) safely Jasper Mayone
2026-11-11 15:28               ` [PATCH v5 3/5] ref-filter: name the worktree of a branch being rebased or bisected Jasper Mayone
2026-11-11 15:28               ` [PATCH v5 4/5] ref-filter: add %(currentworktree) Jasper Mayone
2026-11-11 15:28               ` [PATCH v5 5/5] branch: do not mark the branch the current worktree is rebasing Jasper Mayone
2026-11-11 15:42               ` [PATCH v5 0/5] worktree: treat a branch being rebased or bisected as checked out Ben Knoble
2026-10-21 21:36 ` [RFC PATCH 0/1] worktree list: add --merged and --no-merged Harald Nordgren
2026-10-21 22:12   ` Junio C Hamano
2026-10-22  7:21     ` Harald Nordgren
2026-10-22 17:58   ` Kristoffer Haugsbakk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261111152811.99986-1-me@jaspermayone.com \
    --to=me@jaspermayone.com \
    --cc=ben.knoble@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=haraldnordgren@gmail.com \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=phillip.wood123@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox