Git development
 help / color / mirror / Atom feed
From: Elia Pinto <gitter.spiros@gmail.com>
To: git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 2/4] index-pack: use size_t in write_compressed()
Date: Thu, 19 Nov 2026 07:05:22 +0100	[thread overview]
Message-ID: <20261119060524.775205-2-gitter.spiros@gmail.com> (raw)
In-Reply-To: <av2pOWbYxNDYvS9p@pks.im>

On Wed, Nov 18, 2026 at 02:33:45PM +0100, Patrick Steinhardt wrote:
> Hmm. It's probably an improvement, but the only caller does this:
>
> 	obj[1].idx.offset += write_compressed(f, buf, size);
>
> That's a `struct pack_idx_entry`, but its `offset` field is of type
> `off_t`, which is signed. It feels sufficiently unlikely to ever
> overflow, but should we verify regardless that we don't?

It costs little, and index-pack already does so for the data it
reads: use() dies with "pack too large for current definition of
off_t" when signed_add_overflows(consumed_bytes, bytes). I will do the
same in append_obj_to_pack() in v3.

> Not even an EXPENSIVE one?

I can add one. It needs a local base of 4GiB and a thin pack with a
delta against it. Writing that small delta by hand keeps pack-objects
out of the picture, so only index-pack has to hold the base in memory.
As it still takes a lot of memory and time, I would guard it with its
own variable, like t5608 does with GIT_TEST_CLONE_2GB.

Thanks,
Elia

  reply	other threads:[~2026-11-19  6:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-31 11:39 [PATCH 0/4] use size_t when receiving and verifying packs Elia Pinto
2026-10-31 11:39 ` [PATCH 1/4] unpack-objects: use size_t for object sizes Elia Pinto
2026-10-31 11:39 ` [PATCH 2/4] index-pack: use size_t in write_compressed() Elia Pinto
2026-10-31 11:39 ` [PATCH 3/4] index-pack: use size_t for object sizes Elia Pinto
2026-10-31 11:39 ` [PATCH 4/4] pack-check: use size_t for the size passed to verify callbacks Elia Pinto
2026-11-18  6:56 ` [PATCH v2 0/4] use size_t when receiving and verifying packs Elia Pinto
2026-11-18  6:56   ` [PATCH v2 1/4] unpack-objects: use size_t for object sizes Elia Pinto
2026-11-18 13:33     ` Patrick Steinhardt
2026-11-18 16:59       ` Junio C Hamano
2026-11-19 10:09         ` Patrick Steinhardt
2026-11-19  6:05       ` Elia Pinto
2026-11-19 10:12         ` Patrick Steinhardt
2026-11-19 17:48           ` Elia Pinto
2026-11-18  6:56   ` [PATCH v2 2/4] index-pack: use size_t in write_compressed() Elia Pinto
2026-11-18 13:33     ` Patrick Steinhardt
2026-11-19  6:05       ` Elia Pinto [this message]
2026-11-18  6:56   ` [PATCH v2 3/4] index-pack: use size_t for object sizes Elia Pinto
2026-11-18  6:56   ` [PATCH v2 4/4] pack-check: use size_t for the size passed to verify callbacks Elia Pinto
2026-11-18 13:34     ` Patrick Steinhardt
2026-11-19  6:05       ` Elia Pinto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119060524.775205-2-gitter.spiros@gmail.com \
    --to=gitter.spiros@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox