Git development
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Elia Pinto <gitter.spiros@gmail.com>
Cc: git@vger.kernel.org,
	"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
	"Kristofer Karlsson" <krka@spotify.com>,
	"Han Xin" <hanxin.hx@alibaba-inc.com>,
	"Han Xin" <chiyutianyi@gmail.com>,
	"Junio C Hamano" <gitster@pobox.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v2 1/4] unpack-objects: use size_t for object sizes
Date: Thu, 19 Nov 2026 11:12:02 +0100	[thread overview]
Message-ID: <av7LcjLcTocYH8b-@pks.im> (raw)
In-Reply-To: <20261119060524.775205-1-gitter.spiros@gmail.com>

On Thu, Nov 19, 2026 at 07:05:21AM +0100, Elia Pinto wrote:
> On Wed, Nov 18, 2026 at 02:33:12PM +0100, Patrick Steinhardt wrote:
> > Phew, this commit message really is extremely verbose, and I eventually
> > lost steam reading through it halfways.
> [...]
> > So overall I bet that this message
> > could be condensed to half or even a third of its size without losing
> > much information.
> 
> Fair enough. I will cut it down to what the diff does not show: why
> the cast moves to write_object() and what changes for the user.
> 
> > These casts here make me a bit unhappy, as you also have a patch series
> > in flight that fix `odb_write_object()`. So you'll have to send another
> > patch series after both have landed to remove those again.
> >
> > Would it make more sense to defer this series here until the other one
> > lands?
> 
> Yes. odb_write_object() is changed by "use size_t for a few more
> object and buffer sizes" [1], and parse_object_buffer() and
> fsck_object() by "use size_t when parsing and checking objects" [2].
> Once both are in, write_object() can pass the size on without a cast.
> 
> 4/4 depends on [2] as well (see my reply there), so I will hold back
> 1/4 and 4/4 and resend them on top of [1] and [2]. 2/4 and 3/4 depend
> on neither: 2/4 fixes a bug on all platforms, 3/4 a false "SHA1
> COLLISION FOUND". Unless you or Junio prefer otherwise, I will send
> those two on their own as v3, with your comments on 2/4 addressed.

Do we maybe just want to hold off the whole series until the dependency
lands? As you've seen, having a bunch of similar series out there does
not guarantee that all of them land faster, but rather has the effect
that some of them don't get any reviews at all.

That's not all that surprising, as reviewing these kinds of series is
a bit tedious. That doesn't mean the changes are not useful, it's rather
that we are short on reviewing capacity.

Patrick

  reply	other threads:[~2026-11-19 10:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-31 11:39 [PATCH 0/4] use size_t when receiving and verifying packs Elia Pinto
2026-10-31 11:39 ` [PATCH 1/4] unpack-objects: use size_t for object sizes Elia Pinto
2026-10-31 11:39 ` [PATCH 2/4] index-pack: use size_t in write_compressed() Elia Pinto
2026-10-31 11:39 ` [PATCH 3/4] index-pack: use size_t for object sizes Elia Pinto
2026-10-31 11:39 ` [PATCH 4/4] pack-check: use size_t for the size passed to verify callbacks Elia Pinto
2026-11-18  6:56 ` [PATCH v2 0/4] use size_t when receiving and verifying packs Elia Pinto
2026-11-18  6:56   ` [PATCH v2 1/4] unpack-objects: use size_t for object sizes Elia Pinto
2026-11-18 13:33     ` Patrick Steinhardt
2026-11-18 16:59       ` Junio C Hamano
2026-11-19 10:09         ` Patrick Steinhardt
2026-11-19  6:05       ` Elia Pinto
2026-11-19 10:12         ` Patrick Steinhardt [this message]
2026-11-19 17:48           ` Elia Pinto
2026-11-18  6:56   ` [PATCH v2 2/4] index-pack: use size_t in write_compressed() Elia Pinto
2026-11-18 13:33     ` Patrick Steinhardt
2026-11-19  6:05       ` Elia Pinto
2026-11-18  6:56   ` [PATCH v2 3/4] index-pack: use size_t for object sizes Elia Pinto
2026-11-18  6:56   ` [PATCH v2 4/4] pack-check: use size_t for the size passed to verify callbacks Elia Pinto
2026-11-18 13:34     ` Patrick Steinhardt
2026-11-19  6:05       ` Elia Pinto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av7LcjLcTocYH8b-@pks.im \
    --to=ps@pks.im \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=avarab@gmail.com \
    --cc=chiyutianyi@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=gitter.spiros@gmail.com \
    --cc=hanxin.hx@alibaba-inc.com \
    --cc=krka@spotify.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox