Re: [PATCH] Use 'Everything up to date.' instead of 'Everything up-to-date'

["Ævar Arnfjörð Bjarmason" <avarab@gmail.com>]

On Wed, Jul 27 2022, Jay Berry via GitGitGadget wrote:

> From: Jay Berry <jb2170@selfadjointoperator.com>
>
> There are two hard-coded
> `fprintf(stderr, "Everything up-to-date\n")`
> which I have changed to
> `fprintf(stderr, "Everything up to date.\n")`
> since most other strings used localised versions of `up to date.`
>
> Before (stupidly inconsistent):
> ```
> $ git pull
> Already up to date.
> $ git push
> Everything up-to-date
> ```
> After (consistent):
> ```
> $ git pull
> Already up to date.
> $ git push
> Everything up to date.
> ```
> Signed-off-by: Jay Berry <jb2170@selfadjointoperator.com>
> ---
>     Use 'Everything up to date.' instead of 'Everything up-to-date'
>     
>     There are two hard-coded fprintf(stderr, "Everything up-to-date\n")
>     which I have changed to fprintf(stderr, "Everything up to date.\n")
>     since most other strings used localised versions of up to date.
>     
>     Before (stupidly inconsistent):
>     
>     $ git pull
>     Already up to date.
>     $ git push
>     Everything up-to-date
>     
>     
>     After (consistent):
>     
>     $ git pull
>     Already up to date.
>     $ git push
>     Everything up to date.
>     
>     
>     Signed-off-by: Jay Berry jb2170@selfadjointoperator.com
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1298%2FSelfAdjointOperator%2Fup-to-date-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1298/SelfAdjointOperator/up-to-date-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/1298
>
>  builtin/send-pack.c | 2 +-
>  transport.c         | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/builtin/send-pack.c b/builtin/send-pack.c
> index 64962be0168..cb3c6ff8300 100644
> --- a/builtin/send-pack.c
> +++ b/builtin/send-pack.c
> @@ -338,7 +338,7 @@ int cmd_send_pack(int argc, const char **argv, const char *prefix)
>  	}
>  
>  	if (!ret && !transport_refs_pushed(remote_refs))
> -		fprintf(stderr, "Everything up-to-date\n");
> +		fprintf(stderr, "Everything up to date.\n");
>  
>  	return ret;
>  }
> diff --git a/transport.c b/transport.c
> index 52db7a3cb09..c40d15647ff 100644
> --- a/transport.c
> +++ b/transport.c
> @@ -1416,7 +1416,7 @@ int transport_push(struct repository *r,
>  	if (porcelain && !push_ret)
>  		puts("Done");
>  	else if (!quiet && !ret && !transport_refs_pushed(remote_refs))
> -		fprintf(stderr, "Everything up-to-date\n");
> +		fprintf(stderr, "Everything up to date.\n");

We don't want to take this change for the reasons discussed previously here:

	https://lore.kernel.org/git/CAPig+cRRxYmFqYimTHSi9uzmWU0FRXQ2hGXJK6jYLJcsFce_Rw@mail.gmail.com/
	https://lore.kernel.org/git/20191122180433.GA57478@generichostname/

That "don't" is up for discussion, but a subsequent re-roll should argue
it based on the points raised there.

If we *are* going to change this then:

 * We should mark this for translation with _()
 * Don't have the translation include the \n