Git development
 help / color / mirror / Atom feed
From: "Jay Berry via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Jay Berry <jb2170@selfadjointoperator.com>,
	Jay Berry <jb2170@selfadjointoperator.com>
Subject: [PATCH] Use 'Everything up to date.' instead of 'Everything up-to-date'
Date: Wed, 27 Jul 2022 08:02:07 +0000	[thread overview]
Message-ID: <pull.1298.git.1658908927714.gitgitgadget@gmail.com> (raw)

From: Jay Berry <jb2170@selfadjointoperator.com>

There are two hard-coded
`fprintf(stderr, "Everything up-to-date\n")`
which I have changed to
`fprintf(stderr, "Everything up to date.\n")`
since most other strings used localised versions of `up to date.`

Before (stupidly inconsistent):
```
$ git pull
Already up to date.
$ git push
Everything up-to-date
```
After (consistent):
```
$ git pull
Already up to date.
$ git push
Everything up to date.
```
Signed-off-by: Jay Berry <jb2170@selfadjointoperator.com>
---
    Use 'Everything up to date.' instead of 'Everything up-to-date'
    
    There are two hard-coded fprintf(stderr, "Everything up-to-date\n")
    which I have changed to fprintf(stderr, "Everything up to date.\n")
    since most other strings used localised versions of up to date.
    
    Before (stupidly inconsistent):
    
    $ git pull
    Already up to date.
    $ git push
    Everything up-to-date
    
    
    After (consistent):
    
    $ git pull
    Already up to date.
    $ git push
    Everything up to date.
    
    
    Signed-off-by: Jay Berry jb2170@selfadjointoperator.com

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1298%2FSelfAdjointOperator%2Fup-to-date-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1298/SelfAdjointOperator/up-to-date-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1298

 builtin/send-pack.c | 2 +-
 transport.c         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/builtin/send-pack.c b/builtin/send-pack.c
index 64962be0168..cb3c6ff8300 100644
--- a/builtin/send-pack.c
+++ b/builtin/send-pack.c
@@ -338,7 +338,7 @@ int cmd_send_pack(int argc, const char **argv, const char *prefix)
 	}
 
 	if (!ret && !transport_refs_pushed(remote_refs))
-		fprintf(stderr, "Everything up-to-date\n");
+		fprintf(stderr, "Everything up to date.\n");
 
 	return ret;
 }
diff --git a/transport.c b/transport.c
index 52db7a3cb09..c40d15647ff 100644
--- a/transport.c
+++ b/transport.c
@@ -1416,7 +1416,7 @@ int transport_push(struct repository *r,
 	if (porcelain && !push_ret)
 		puts("Done");
 	else if (!quiet && !ret && !transport_refs_pushed(remote_refs))
-		fprintf(stderr, "Everything up-to-date\n");
+		fprintf(stderr, "Everything up to date.\n");
 
 done:
 	free_refs(local_refs);

base-commit: e72d93e88cb20b06e88e6e7d81bd1dc4effe453f
-- 
gitgitgadget

             reply	other threads:[~2022-07-27  8:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-27  8:02 Jay Berry via GitGitGadget [this message]
2022-07-27  9:15 ` [PATCH] Use 'Everything up to date.' instead of 'Everything up-to-date' Ævar Arnfjörð Bjarmason
2022-07-27 13:35   ` Paul Smith
2022-07-28 14:27     ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.1298.git.1658908927714.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jb2170@selfadjointoperator.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox