From: Derrick Stolee <stolee@gmail.com>
To: Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: UBSan failing on expensive test(s)
Date: Fri, 15 May 2026 22:55:49 -0400 [thread overview]
Message-ID: <256d83f3-dd0b-4a86-954a-de78ec65be6a@gmail.com> (raw)
In-Reply-To: <20260516021343.GA174647@coredump.intra.peff.net>
On 5/15/26 10:13 PM, Jeff King wrote:
> On Sat, May 16, 2026 at 08:43:07AM +0900, Junio C Hamano wrote:
>
>> This started happening on 'next' that runs EXPENSIVE tests thanks to
>> Dscho's recent updates to enable them in CI.
>>
>> https://github.com/git/git/actions/runs/25896439353/job/76110441841#step:10:2172
>>
>> It claims that """
>>
>> commit.c:1574:6: runtime error: signed integer overflow:
>> -2147483648 - 1 cannot be represented in type 'int'
>>
>> """.
>>
>> Another is related in the sense that it used to be hidden behind
>> EXPENSIVE prerequisite, but is probably unrelated.
>>
>> https://github.com/git/git/actions/runs/25896439353/job/76110441842#step:10:156
>
> These patches should fix both.
>
> [1/2]: apply: plug leak on "patch too large" error
> [2/2]: commit: handle large commit messages in utf8 verification
Thanks for the fast fixes. I agree with you that 2GB commit
messages are silly, but the methods you change could be used
for other things so having better types is good. We can
consider blocking large commits as a feature another time.
-Stolee
prev parent reply other threads:[~2026-05-16 2:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 23:43 UBSan failing on expensive test(s) Junio C Hamano
2026-05-16 2:13 ` Jeff King
2026-05-16 2:16 ` [PATCH 1/2] apply: plug leak on "patch too large" error Jeff King
2026-05-16 2:23 ` [PATCH 2/2] commit: handle large commit messages in utf8 verification Jeff King
2026-05-16 2:55 ` Derrick Stolee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=256d83f3-dd0b-4a86-954a-de78ec65be6a@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox