make install bug?

make install bug?

[eschvoca]

Using the latest git on "make prefix=/home/eschvoca/apps/git-0.99.9m
install" I get the following error:

make[1]: Entering directory `/home/eschvoca/downloads/git-0.99.9m/templates'
: no custom templates yet
install -d -m755 '/home/eschvoca/share/git-core/templates/'
(cd blt && tar cf - .) | \
(cd '/home/eschvoca/share/git-core/templates/' && tar xf -)
tar: This does not look like a tar archive
tar: Skipping to next header
tar: Error exit delayed from previous errors
make[1]: *** [install] Error 2


I can fix the problem by changing templates/Makefile to the following:

install: all
    $(INSTALL) -d -m755 $(call shellquote,$(DESTDIR)$(template_dir))
    (cd blt && $(TAR) cf - . > /tmp/a.tar) | \
    (cd $(call shellquote,$(DESTDIR)$(template_dir)) && $(TAR) xf /tmp/a.tar)

Re: make install bug?

[Junio C Hamano]

eschvoca <eschvoca@gmail.com> writes:

> I can fix the problem by changing templates/Makefile to the following:
>
> install: all
>     $(INSTALL) -d -m755 $(call shellquote,$(DESTDIR)$(template_dir))
>     (cd blt && $(TAR) cf - . > /tmp/a.tar) | \
>     (cd $(call shellquote,$(DESTDIR)$(template_dir)) && $(TAR) xf /tmp/a.tar)

Here is my guess.  Could you try, from your interactive shell:

	$ (unset CDPATH; make install)

first without the above "fix" (your "fixed" pipe does not make
any sense --- what are the data passed between pipe upstream and
downstream?)?

If that makes the problem go away, then your environment is
broken --- my guess is that you are exporting CDPATH to
non-interactive scripts.  Don't do that.

I once googled for "CDPATH" and saw many "guide to unix" type
webpages talk about "CDPATH environment variable"; they are the
real culprit to cause this confusion in peoples' .bash_profile.
CDPATH might be a nice variable for interactive shells, but is a
horrible one if made environment.

Re: make install bug?

[eschvoca]

You are right, CDPATH is the problem.  I am no longer exporting CDPATH.

e

On 12/12/05, Junio C Hamano <junkio@cox.net> wrote:
> eschvoca <eschvoca@gmail.com> writes:
>
> > I can fix the problem by changing templates/Makefile to the following:
> >
> > install: all
> >     $(INSTALL) -d -m755 $(call shellquote,$(DESTDIR)$(template_dir))
> >     (cd blt && $(TAR) cf - . > /tmp/a.tar) | \
> >     (cd $(call shellquote,$(DESTDIR)$(template_dir)) && $(TAR) xf /tmp/a.tar)
>
> Here is my guess.  Could you try, from your interactive shell:
>
>         $ (unset CDPATH; make install)
>
> first without the above "fix" (your "fixed" pipe does not make
> any sense --- what are the data passed between pipe upstream and
> downstream?)?
>
> If that makes the problem go away, then your environment is
> broken --- my guess is that you are exporting CDPATH to
> non-interactive scripts.  Don't do that.
>
> I once googled for "CDPATH" and saw many "guide to unix" type
> webpages talk about "CDPATH environment variable"; they are the
> real culprit to cause this confusion in peoples' .bash_profile.
> CDPATH might be a nice variable for interactive shells, but is a
> horrible one if made environment.
>
>