From: Avery Pennarun <apenwarr@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Nanako Shiraishi <nanako3@lavabit.com>,
Marc Fournier <marc.fournier@camptocamp.com>,
git@vger.kernel.org
Subject: Re: git-subtree: directory mismatch
Date: Wed, 25 Nov 2009 14:48:13 -0500 [thread overview]
Message-ID: <32541b130911251148v70a5dc77k9936881d0b382ec2@mail.gmail.com> (raw)
In-Reply-To: <7v7htexuxc.fsf@alter.siamese.dyndns.org>
On Wed, Nov 25, 2009 at 2:31 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Avery Pennarun <apenwarr@gmail.com> writes:
>> I've read through the thread (I do remember skimming it awhile ago)
>> but can't find patches for the syntax actually under discussion.
>
> I very much prefer gmane threading when following discussion over all the
> other mail archives, but this shows one thing I really dislike about it.
[...]
> Look at http://github.com/gitster/git/commits/jc/merge-theirs/
I also tried simply searching for things like 'git "-xsubtree"' in
google, with no luck. But thanks for the link.
> and found this series in there. It applies to v1.6.0-rc0~245 (no, I won't
> be rebasing this myself---I don't have time for that while preparing for
> the pre-release feature freeze).
I did a test merge and it looks like a ton of conflicts, but they seem
to be pretty understandable ones, at least. I don't mind doing the
rebase and resubmitting the patches, since it's sure less work than
figuring out how to do it from scratch myself. Some questions though:
- What was the reason this never got merged? What changes are needed
to rectify that?
- Considering the earlier discussion, do we want to leave out the
actual -Xtheirs feature and just have -Xours and -Xsubtree?
- If I rebase them and the changes turn out to be minimal, do they
still need a signed-off-by Junio? (He obviously owns part of the
copyright and has previously signed off, but he also won't have signed
off the rebased patches verbatim, so I'm confused.)
Thanks,
Avery
next prev parent reply other threads:[~2009-11-25 19:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-24 19:53 git-subtree: directory mismatch Marc Fournier
2009-11-24 21:48 ` Avery Pennarun
2009-11-24 23:08 ` Nanako Shiraishi
2009-11-25 18:28 ` Avery Pennarun
2009-11-25 19:31 ` Junio C Hamano
2009-11-25 19:48 ` Avery Pennarun [this message]
2009-11-25 20:20 ` Junio C Hamano
2009-11-25 23:17 ` Johannes Schindelin
2009-11-25 23:20 ` Avery Pennarun
2009-11-25 23:41 ` Björn Steinbrink
2009-11-25 23:45 ` Avery Pennarun
2009-11-25 14:32 ` Marc Fournier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32541b130911251148v70a5dc77k9936881d0b382ec2@mail.gmail.com \
--to=apenwarr@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=marc.fournier@camptocamp.com \
--cc=nanako3@lavabit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox