From: Frank Sorenson <frank@tuxrocks.com>
To: Petr Baudis <pasky@ucw.cz>
Cc: Git Mailing List <git@vger.kernel.org>,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] Fix git-fsck-cache segfault on invalid tag
Date: Fri, 20 May 2005 08:36:16 -0600 [thread overview]
Message-ID: <428DF5E0.6030106@tuxrocks.com> (raw)
In-Reply-To: <20050520085047.GA27787@pasky.ji.cz>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Petr Baudis wrote:
> Dear diary, on Fri, May 20, 2005 at 09:00:41AM CEST, I got a letter
> where Frank Sorenson <frank@tuxrocks.com> told me that...
>
>>git-fsck-cache will segfault if a tag contains a non-existent sha1. This
>>patch fixes fsck-cache to report the invalid tag and not die.
>
>
> Oh. I've fixed this too but didn't even get to commit it yet. :-)
Okay. At least we fixed the same bug. It was a good exercise for me to
track it down anyway :)
> My error message is
>
> error("%s: invalid sha1 pointer %.40s", path, hexname);
>
> I'd prefer that (at least use the error() call). The .40 is there since
> it has a newline on its own.
Great. Your message looks fine. It looks like error() should work fine
as well.
Frank
- --
Frank Sorenson - KD7TZK
Systems Manager, Computer Science Department
Brigham Young University
frank@tuxrocks.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFCjfXgaI0dwg4A47wRAikrAKCvPmZBQK34sdnnY61/meuewu2jzQCfT7Qf
TDSNgfp3WBJOTvWG5uhwX4s=
=CUF2
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2005-05-20 14:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-20 7:00 [PATCH] Fix git-fsck-cache segfault on invalid tag Frank Sorenson
2005-05-20 8:50 ` Petr Baudis
2005-05-20 13:58 ` Junio C Hamano
2005-05-20 14:36 ` Frank Sorenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=428DF5E0.6030106@tuxrocks.com \
--to=frank@tuxrocks.com \
--cc=git@vger.kernel.org \
--cc=pasky@ucw.cz \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox