From: Junio C Hamano <junkio@cox.net>
To: Petr Baudis <pasky@ucw.cz>
Cc: Frank Sorenson <frank@tuxrocks.com>,
Git Mailing List <git@vger.kernel.org>,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] Fix git-fsck-cache segfault on invalid tag
Date: Fri, 20 May 2005 06:58:07 -0700 [thread overview]
Message-ID: <7voeb6uhhs.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20050520085047.GA27787@pasky.ji.cz> (Petr Baudis's message of "Fri, 20 May 2005 10:50:47 +0200")
>>>>> "PB" == Petr Baudis <pasky@ucw.cz> writes:
>> obj = lookup_object(sha1);
>> + if (!obj) {
>> + fprintf(stderr, "invalid tag %s - %s\n", path, hexname);
>> + return;
>> + }
>> ...
PB> My error message is
PB> error("%s: invalid sha1 pointer %.40s", path, hexname);
PB> I'd prefer that (at least use the error() call).
Ack.
I was about to say "doesn't lookup_object() give its own error
message before you say that, though?" because I remembered a
comment to that effect around ll 410 that gets the heads from
the command line argument, and then looked at lookup_object()
implementation to find that it does _not_ give error message.
So if you are going to do this, would you mind giving similar
error message to that command line heads stuff while you are at
it, please?
next prev parent reply other threads:[~2005-05-20 13:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-20 7:00 [PATCH] Fix git-fsck-cache segfault on invalid tag Frank Sorenson
2005-05-20 8:50 ` Petr Baudis
2005-05-20 13:58 ` Junio C Hamano [this message]
2005-05-20 14:36 ` Frank Sorenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7voeb6uhhs.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=frank@tuxrocks.com \
--cc=git@vger.kernel.org \
--cc=pasky@ucw.cz \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox