* [PATCH] builtin-reflog.c: typo ref --> argv[i], could cause segfault
@ 2008-01-05 1:11 Brandon Casey
2008-01-05 1:22 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Brandon Casey @ 2008-01-05 1:11 UTC (permalink / raw)
To: Git Mailing List, Junio C Hamano
Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
---
builtin-reflog.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin-reflog.c b/builtin-reflog.c
index f422693..5e54989 100644
--- a/builtin-reflog.c
+++ b/builtin-reflog.c
@@ -394,7 +394,7 @@ static int cmd_reflog_delete(int argc, const char **argv, const char *prefix)
int recno;
if (!spec) {
- status |= error("Not a reflog: %s", ref);
+ status |= error("Not a reflog: %s", argv[i]);
continue;
}
--
1.5.4.rc2.1119.g6fdf-dirty
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] builtin-reflog.c: typo ref --> argv[i], could cause segfault
2008-01-05 1:11 [PATCH] builtin-reflog.c: typo ref --> argv[i], could cause segfault Brandon Casey
@ 2008-01-05 1:22 ` Junio C Hamano
2008-01-05 1:35 ` Brandon Casey
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2008-01-05 1:22 UTC (permalink / raw)
To: Brandon Casey; +Cc: Git Mailing List
Brandon Casey <casey@nrlssc.navy.mil> writes:
> Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
> ---
> builtin-reflog.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/builtin-reflog.c b/builtin-reflog.c
> index f422693..5e54989 100644
> --- a/builtin-reflog.c
> +++ b/builtin-reflog.c
> @@ -394,7 +394,7 @@ static int cmd_reflog_delete(int argc, const char **argv, const char *prefix)
> int recno;
>
> if (!spec) {
> - status |= error("Not a reflog: %s", ref);
> + status |= error("Not a reflog: %s", argv[i]);
> continue;
> }
Bad Brandon! Looking at 'next' while everybody is asked to work
on finding and fixing bugs on 'master' while -rc freeze.
Just kidding. Thanks, the code is obviously correct, and will
queue.
I am not so surprised to see bugs in relatively new code that is
only in 'next', especially this one that no Porcelains already
use.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] builtin-reflog.c: typo ref --> argv[i], could cause segfault
2008-01-05 1:22 ` Junio C Hamano
@ 2008-01-05 1:35 ` Brandon Casey
0 siblings, 0 replies; 3+ messages in thread
From: Brandon Casey @ 2008-01-05 1:35 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Git Mailing List
Junio C Hamano wrote:
> Bad Brandon! Looking at 'next' while everybody is asked to work
> on finding and fixing bugs on 'master' while -rc freeze.
No more, I promise. :)
-brandon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-01-05 1:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-05 1:11 [PATCH] builtin-reflog.c: typo ref --> argv[i], could cause segfault Brandon Casey
2008-01-05 1:22 ` Junio C Hamano
2008-01-05 1:35 ` Brandon Casey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox