Git development
 help / color / mirror / Atom feed
* [PATCH] t9113-*.sh: provide user feedback when test skipped
@ 2008-07-08 23:18 Ramsay Jones
  0 siblings, 0 replies; only message in thread
From: Ramsay Jones @ 2008-07-08 23:18 UTC (permalink / raw)
  To: GIT Mailing-list; +Cc: Junio C Hamano


Currently this test simply exits without providing any
feedback at all.  Tell user if the test is being skipped
and provide a hint as to how the test may be enabled.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
 t/t9113-git-svn-dcommit-new-file.sh |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/t/t9113-git-svn-dcommit-new-file.sh b/t/t9113-git-svn-dcommit-new-file.sh
index 31c929b..8da8ce5 100755
--- a/t/t9113-git-svn-dcommit-new-file.sh
+++ b/t/t9113-git-svn-dcommit-new-file.sh
@@ -7,12 +7,18 @@
 # I don't like the idea of taking a port and possibly leaving a
 # daemon running on a users system if the test fails.
 # Not all git users will need to interact with SVN.
-test -z "$SVNSERVE_PORT" && exit 0
 
 test_description='git-svn dcommit new files over svn:// test'
 
 . ./lib-git-svn.sh
 
+if test -z "$SVNSERVE_PORT"
+then
+	say 'skipping svnserve test. (set $SVNSERVE_PORT to enable)'
+	test_done
+	exit
+fi
+
 start_svnserve () {
 	svnserve --listen-port $SVNSERVE_PORT \
 	         --root "$rawsvnrepo" \
-- 
1.5.6

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2008-07-09 17:42 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-08 23:18 [PATCH] t9113-*.sh: provide user feedback when test skipped Ramsay Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox